Overhaul of Inequality Theory #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostis
reviewed
Mar 24, 2025
src/main/java/de/learnlib/ralib/automata/guards/AtomicGuardExpression.java
Outdated
Show resolved
Hide resolved
kostis
reviewed
Mar 24, 2025
kostis
requested changes
Mar 25, 2025
src/main/java/de/learnlib/ralib/theory/inequality/LesserSuffixValue.java
Outdated
Show resolved
Hide resolved
src/main/java/de/learnlib/ralib/theory/equality/EqualityGuard.java
Outdated
Show resolved
Hide resolved
src/test/java/de/learnlib/ralib/theory/inequality/IneqGuardMergeTest.java
Outdated
Show resolved
Hide resolved
src/test/java/de/learnlib/ralib/theory/inequality/IntervalGuardInstaniateTest.java
Outdated
Show resolved
Hide resolved
src/test/java/de/learnlib/ralib/theory/inequality/IneqTheoryRestrictionsTest.java
Outdated
Show resolved
Hide resolved
kostis
reviewed
Mar 26, 2025
src/test/java/de/learnlib/ralib/oracles/mto/BranchMergingTest.java
Outdated
Show resolved
Hide resolved
kostis
reviewed
Mar 26, 2025
src/main/java/de/learnlib/ralib/theory/inequality/InequalityTheoryWithEq.java
Outdated
Show resolved
Hide resolved
fhowar
reviewed
Mar 27, 2025
There was a problem hiding this comment.
Do we really need right closed and left closed? Can't this be modelled in the type DataValue? We could introduce -infty and +infty (not sure of the implications) but using two field for either side begs for inconsistency issues
There was a problem hiding this comment.
The right closed and left closed booleans are to allow guards such as r1 <= s1 <= r2. I am unsure how this can be modeled using -infty and +infty in a simple and straightforward way. Could you elaborate on what inconsistency issues you foresee?
| * @param renaming - the conditions to apply to other | ||
| * @param solver - a constraint solver | ||
| */ | ||
| public boolean isSemanticallyEquivalent(SDT other, Expression<Boolean> renaming, NativeZ3Solver solver) { |
There was a problem hiding this comment.
renaming should have a better name
kostis
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This RP completely reworks the Inequality Theory from the ground up to make it more intuitive and to fix various bugs related to guard merging. It also introduces closed intervals to the IntervalGuard to enable <= and >= guards.
In addition, this RP adds support for suffix optimization to the Inequality Theory and fixes various bugs related to suffix optimization in general.