-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to appuser to avoid root #43
Conversation
* avoid git package - unused since #30 * re-order and document steps * use environment variables as parameter * expose ports Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
4ea3a8d
to
423308a
Compare
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
@c-chroniko : I've used some of your previous feedback here (for |
Do the changes in this PR only address the subject of the request, or does it include other stylistic changes? I'm having trouble going through such a large diff and identifying whether it's successful in its goal. |
My apologies: You are right to think this patche is too big! |
@c-chroniko: this comparison is diffing only what this specific PR is about: reworking the Dockerfiles to create the app user+group and adapt the composer and workflow accordingly. I don't think I can rebase this branch on main w/o braking the build and conflicting other pending PR... Maybe you can review #40 and then #42 after #40 will be merged? |
Back to draft to avoid further confusion. |
Signed-off-by: Benoit Donneaux <[email protected]>
@c-chroniko : this PR is clean now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Depends on #40 and #42
Close #34
The application is still installed via pip as root, but the command run as non-root.
The
appuser
is created inside the container with uid=1000 and gid=1000 by default.But one can change those default either:
--build-arg uid=...
MW_MAILBOX_UID
andMW_RELAY_UID
)The later is the option now used to test the image in the workflow because the GH runner used uid=1001.