Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS wheels: drop setuptools-scm #63

Closed
wants to merge 7 commits into from

Conversation

crwood
Copy link
Member

@crwood crwood commented Nov 5, 2024

This PR removes the use of setuptools-scm in favor of declaring a hardcoded version string, effectively fixing the failing (macOS) wheel builds. Builds had been failing previously because newer versions of setuptools-scm can no longer be configured via setup.py (and must use pyproject.toml).

This is not ideal solution: in keeping up with recent changes in the Python packaging ecosystem, it would be preferable to shift project configuration from setup.py to pyproject.toml, however, this project's setup.py currently contains custom/milksnake-specific hooks that would presumably be need to re-implemented elsewhere (and is beyond the scope of this PR).

Note that a version string was already being hardcoded in nix/python-challenge-bypass-ristretto.nix (so setuptools-scm could not have been used to handle any/all version-string declaration anyway). I've documented this in a comment in both files; future maintainers should update the version string in both places until the entire project can be migrated to using pyproject.toml.

@crwood crwood changed the title Try fixing macOS wheels Fix macOS wheels: drop setuptools-scm Nov 5, 2024
@crwood crwood marked this pull request as ready for review November 5, 2024 18:43
@hacklschorsch
Copy link
Member

Looks good to me!

Where can I see the difference in macOS wheels not working before and now working?
I thought I had already fixed this, else I hadn't bumped the version in my earlier PR :/

@crwood
Copy link
Member Author

crwood commented Nov 5, 2024

Where can I see the difference in macOS wheels not working before and now working?

I had tried building locally and got the failure shown in #58 (which you could also see here -- albeit under ZKAPAuthorizer).

I thought I had already fixed this, else I hadn't bumped the version in my earlier PR :/

Oh, that's interesting. I hadn't noticed that your change passed the macOS builds independently at the time I started this (probably because it was red at the time that we merged -- but for different reasons). I'm still not sure I understand how/why setuptools-scm "Just Works" there and not here, but I'm glad that it does.

Feel free to reject/close this (and, I guess, close #58?). Sorry!

@hacklschorsch
Copy link
Member

Should we still merge this now that the wheels build fine without it?

@crwood
Copy link
Member Author

crwood commented Nov 11, 2024

Nah, let's just close it. I still don't know what led to the original breakage here but we don't gain much by trying to diagnose it (plus, a lot of adjacent things were broken at the time so it could have been related to something that is no longer a cause).

@crwood crwood closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants