Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement Nix CI workflow on GitHub instead of CircleCI #10

Draft
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

btlogy
Copy link

@btlogy btlogy commented Dec 3, 2024

No description provided.

@btlogy btlogy force-pushed the 4134.nix-on-github branch 15 times, most recently from 7fe97b1 to 6cf6bf7 Compare December 3, 2024 22:51
- ipython-8.24.0 not supported for interpreter python3.9
- magic-wormhole-transit-relay-0.2.1 not supported for interpreter python3.12

Signed-off-by: Benoit Donneaux <[email protected]>
@btlogy btlogy force-pushed the 4134.nix-on-github branch 4 times, most recently from 4f429fd to 58a18cf Compare December 4, 2024 16:25
@btlogy btlogy force-pushed the 4134.nix-on-github branch from 58a18cf to c13e42f Compare December 4, 2024 16:31
Signed-off-by: Benoit Donneaux <[email protected]>
- tkinter-7.3.12 not supported for interpreter pypy3.9

Signed-off-by: Benoit Donneaux <[email protected]>
@btlogy btlogy self-assigned this Dec 4, 2024
@hacklschorsch
Copy link
Member

hacklschorsch commented Dec 4, 2024

I have some updates for tahoe-lafs on-nix dependencies in here: PrivateStorageio/ZKAPAuthorizer#481

@hacklschorsch
Copy link
Member

Much better than packaging things IRL ;)

... it's old (3.12 is the default), it's not in
the NixOS binary caches, some dependency fails building
and fixing it feels like picking over bones
... it has served its purpose (development) and is using runner time
@hacklschorsch
Copy link
Member

hacklschorsch commented Dec 5, 2024

I saw that, contrary to what I had written in my commit message 68f706e, also Python 3.10 succeeds, for which a bunch of dependencies have to be built because they are not in the NixOS cache anymore.

But really IDK what we learn from making old Python versions work on NixOS - I think only testing the current stable channel's default (here: 3.12) is fine.

@ben do you see a reason why we shouldn't remove Python 3.11 as well?

@btlogy
Copy link
Author

btlogy commented Dec 6, 2024

@ben do you see a reason why we shouldn't remove Python 3.11 as well?

My understanding of the implications is too weak I'm afraid.
I would generally think it's good to stick to one stable/well supported version to checks PRs (e.g.: Python 3.12 I guess), and try to foreseen possible upcoming issues in the next version (e.g.: Python 3.13?)

Though, his is sometime problematic for LTS distros which keeps using stable version longer than what upstream keeps supporting...

But I've not yet a clear idea what this means for NixOS honestly.

@meejah
Copy link

meejah commented Dec 6, 2024

Though, his is sometime problematic for LTS distros which keeps using stable version longer than what upstream keeps supporting...

For reference:

  • Python 3.12 is supported until 2028-10.
  • Python 3.11 is supported until 2027-10.

@btlogy
Copy link
Author

btlogy commented Dec 7, 2024

Though, this is sometime problematic for LTS distros which keeps using stable version longer than what upstream keeps supporting...

For reference:

* Python 3.12 is supported until 2028-10.

* Python 3.11 is supported until 2027-10.

So we have time.

But what I meant is that some distro support things like Python longer than the upstream developers.
For instance, I was looking at the EOL for this OracleLinux 8 to see how long they would support Python 3.9...
And look what I've found there:

python 3.6 EOL July 2029

😱

@hacklschorsch
Copy link
Member

hacklschorsch commented Dec 13, 2024

Though, his is sometime problematic for LTS distros which keeps using stable version longer than what upstream keeps supporting...

For reference:

  • Python 3.12 is supported until 2028-10.
  • Python 3.11 is supported until 2027-10.

Thanks @meejah.

I still don't know whether we learn enough from running our tests with non-standard Python versions on fast-moving platforms like NixOS.

I propose to check all Pythons on one platform (say, Debian or some docker container that is useful for this) and then check all the different OSes we want to support with whatever is a sensible default for them in ticket: 4145.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants