-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[add] ledger_app.toml C manifest #98
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
=======================================
Coverage 80.43% 80.43%
=======================================
Files 3 3
Lines 46 46
=======================================
Hits 37 37
Misses 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cd732af
to
947d5a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say part of the objective here is to get rid of some specific settings everywhere.
Another one that is present at multiple location is the list of compatible devices, maybe we can add it there?
For the test part, I'm not sure, I think both @agrojean-ledger and @sgliner-ledger had some usage, and therefore could have needed fields here?
I'm thinking for example at the flags
input argument of the reusable_build workflow.
@xchapron-ledger I'm creating an issue on the workflow repo as I feel it's the more relevant place for such discussion. |
@lpascal-ledger @xchapron-ledger I guess we either need to change the name of this manifest file or we need to update how we detect rust apps in various scripts (I have We could put a language field directly in the manifest for instance... |
@agrojean-ledger see here for discussion. |
736139c
to
c3a3d2d
Compare
980982f
to
a72ec36
Compare
a72ec36
to
0202c21
Compare
0202c21
to
bccfb4f
Compare
No description provided.