forked from onflow/ledger-app-flow
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New node registration transaction #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port PR#31 from LedgerHQ/app-flow
Update zxlib and fix breaking changes
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@ledgerhq/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected] |
fvalette-ledger
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
develop
Changes
SCO.17
to the app. All existing transactions are unchanged (supported transactions are listed in the manifest file)More on the new transaction
The new transaction
SCO.17
registers a node to the network using a new extra parameter: the proof of possession of a staking private key.The PR keeps the old version of the node registration transaction
SCO.03
(without the extra parameter) for backward compatibility of the Ledger wallet. The clients would callSCO.17
orSCO.03
depending on the transaction version supported by the chain.Currently, only
SCO.03
is supported. In the near future, only the new transaction versionSCO.17
will be supported through an on-chain contract upgrade. The versionSCO.03
will become obsolete and can be removed from the flow ledger app in a future update.What is the proof of possession of the private key:
Flow protocol uses BLS signature to authenticate participating nodes in the protocol, including the proof of stake consensus algorithm. BLS signature aggregation requires a mechanism to prevent rogue key attacks. The mechanism chosen in the Flow protocol is called the proof of possession (PoP) of the private key. This requires the nodes to present a public proof of knowing the staking private key corresponding to the staking public key they submit to the network. The new registration transaction
SCO.17
is the transaction that node operators use to submit their public info to the network, including the PoP of the staking private key.