Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings tests #142

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Settings tests #142

merged 2 commits into from
Jan 9, 2025

Conversation

iartemov-ledger
Copy link
Contributor

@iartemov-ledger iartemov-ledger commented Jan 6, 2025 •
edited
Loading

Checklist

  • test_settings
  • test_info
  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped - no need as the app code has not changed in this PR

Depends in #140 that must be merged 1st (the present branch has been created from iartemov-ledger:stax_flex_test_fix whose commits will disappear after #140 merge to develop).

⚠️ there are a lot of new snapshots as the tests navigate through all screens and check that new settings are taken into account. We might want to sacrifice a part of it or maybe another approach exists ?

@iartemov-ledger iartemov-ledger mentioned this pull request Jan 7, 2025
Merged
7 tasks
@iartemov-ledger iartemov-ledger marked this pull request as ready for review January 7, 2025 16:21
@iartemov-ledger iartemov-ledger merged commit 40453af into LedgerHQ:develop Jan 9, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedelavergne-ledger cedelavergne-ledger cedelavergne-ledger approved these changes

@tdejoigny-ledger tdejoigny-ledger Awaiting requested review from tdejoigny-ledger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iartemov-ledger @cedelavergne-ledger