Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending and fixing transaction tests #145

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Extending and fixing transaction tests #145

merged 3 commits into from
Jan 21, 2025

Conversation

iartemov-ledger
Copy link
Contributor

@iartemov-ledger iartemov-ledger commented Jan 21, 2025 •
edited
Loading

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped - not needed as the app's code does not change

@iartemov-ledger
Extending and fixing transacation tests
9b6b560 
- several (chained) sub-commands covered
- change case covered
- amount values corrected
@iartemov-ledger iartemov-ledger force-pushed the iar/chained_command_with_change branch from 8db41af to 9b6b560 Compare January 21, 2025 10:10
@iartemov-ledger iartemov-ledger marked this pull request as ready for review January 21, 2025 10:20
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 21, 2025
View reviewed changes
src/monero_crypto.c Dismissed Show dismissed Hide dismissed
cedelavergne-ledger
cedelavergne-ledger reviewed Jan 21, 2025
View reviewed changes
Copy link

@cedelavergne-ledger cedelavergne-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor updates

tests/monero_client/monero_cmd.py Outdated Show resolved Hide resolved
tests/monero_client/monero_cmd.py Outdated Show resolved Hide resolved
tests/monero_client/monero_cmd.py Outdated Show resolved Hide resolved
iartemov-ledger added a commit that referenced this pull request Jan 21, 2025
@iartemov-ledger
Addressing remarks from #145
fafe0df
@iartemov-ledger
Copy link
Contributor Author

Just minor updates

@iartemov-ledger iartemov-ledger force-pushed the iar/chained_command_with_change branch from fafe0df to 734c397 Compare January 21, 2025 15:45
@iartemov-ledger iartemov-ledger merged commit 5e13e33 into develop Jan 21, 2025
43 checks passed
@iartemov-ledger iartemov-ledger deleted the iar/chained_command_with_change branch January 21, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedelavergne-ledger cedelavergne-ledger cedelavergne-ledger approved these changes

@tdejoigny-ledger tdejoigny-ledger Awaiting requested review from tdejoigny-ledger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iartemov-ledger @cedelavergne-ledger