Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update plugin to support recent changes on Uniswap #21

Closed
wants to merge 7 commits into from

Conversation

tdejoigny-ledger
Copy link
Contributor

@tdejoigny-ledger tdejoigny-ledger commented Nov 1, 2024

  • add sweep method support (widely used now)
  • display unwrap amount instead of exact in output amount
  • remove check (code and test) for the output amount of exact in which can be equal to 0
  • drop an extra parameter added recently in the call data (to track the transaction coming from Uniswap frontend but useless for the plugin)
  • remove a check in the tx content which assert value == 0
  • update the fields wording
  • update the golden snapshots

@tdejoigny-ledger tdejoigny-ledger marked this pull request as ready for review November 4, 2024 15:39
@tdejoigny-ledger tdejoigny-ledger changed the title drop unexpected parameter instead of stopping the parsing update plugin to support recent changes on Uniswap Nov 16, 2024
@fbeutin-ledger
Copy link
Contributor

fbeutin-ledger commented Dec 3, 2024

Superseeded #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants