Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Flex support #89

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Add Flex support #89

merged 2 commits into from
Jun 11, 2024

Conversation

agrojean-ledger
Copy link

@agrojean-ledger agrojean-ledger commented Jun 5, 2024 •
edited
Loading

  • Add Flex support
  • Update NBGL API calls
  • Update tests
  • Use standard Makefile

Checklist

  • Target branch is develop
  • Application version has been bumped

@agrojean-ledger agrojean-ledger changed the title Add Flex support + Update NBGL API calls + Update tests + Use standard Makefile Add Flex support Jun 5, 2024
cedelavergne-ledger
cedelavergne-ledger reviewed Jun 6, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
cedelavergne-ledger
cedelavergne-ledger reviewed Jun 6, 2024
View reviewed changes
src/main.c Outdated Show resolved Hide resolved
tdejoigny-ledger
tdejoigny-ledger reviewed Jun 7, 2024
View reviewed changes
Copy link

@tdejoigny-ledger tdejoigny-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

settings persistency quickly tested on Flex device : it's working !

tests/python/test_solana.py Outdated Show resolved Hide resolved
@agrojean-ledger agrojean-ledger force-pushed the flex-port branch 2 times, most recently from 8a6fd61 to f50db61 Compare June 10, 2024 14:34
cedelavergne-ledger
cedelavergne-ledger reviewed Jun 11, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@agrojean-ledger agrojean-ledger merged commit fb0a337 into develop Jun 11, 2024
118 checks passed
@agrojean-ledger agrojean-ledger deleted the flex-port branch June 11, 2024 12:18
@t-nelson
Copy link

why was this not four PRs? the diff is incomprehensible. is this a security device or not?

@tdejoigny-ledger
Copy link

why was this not four PRs? the diff is incomprehensible. is this a security device or not?

Yes this PR adds support for a new device. The diff is totally understandable, only a few code files have been modified, all other files are snapshots from the device.

@agrojean-ledger
Copy link
Author

@t-nelson the main goal was to add support for the new device, but we have decided to make some improvements of the code based on the latest SDK and test framework features.

We are in the process of doing this for the various apps that we maintain :

LedgerHQ/app-hedera#66
LedgerHQ/app-xrp#51

...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdejoigny-ledger tdejoigny-ledger tdejoigny-ledger left review comments

@cedelavergne-ledger cedelavergne-ledger cedelavergne-ledger approved these changes

@fbeutin-ledger fbeutin-ledger Awaiting requested review from fbeutin-ledger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agrojean-ledger @t-nelson @tdejoigny-ledger @cedelavergne-ledger