fix: support priority fees instructions on swap [LIVE-11792] #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Justkant
commented
Nov 5, 2024
Justkant
added a commit
to LedgerHQ/app-exchange
that referenced
this pull request
Nov 5, 2024
I had to update the solana_cmd_builder to support more instructions and to generate a golden run for the new tests Related app-solana PR: LedgerHQ/app-solana#97
3 tasks
|
tdejoigny-ledger
approved these changes
Nov 6, 2024
Justkant
added a commit
to LedgerHQ/app-exchange
that referenced
this pull request
Nov 6, 2024
I had to update the solana_cmd_builder to support more instructions and to generate a golden run for the new tests Related app-solana PR: LedgerHQ/app-solana#97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
developIn order to support transactions with priority fees on swap we need to allow for more steps
I currently don't check the amount for
Max feesand don't really know if we can or shouldI tested the changes with the test app-exchange