Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ (signer-eth) [NO-ISSUE]: Add nano pki/web3check support #596

Closed
wants to merge 6 commits into from
Closed

✨ (signer-eth) [NO-ISSUE]: Add nano pki/web3check support #596

wants to merge 6 commits into from

Conversation

mbertin-ledger
Copy link
Member

@mbertin-ledger mbertin-ledger commented Jan 8, 2025 •
edited by aussedatlo
Loading

📝 Description

Add nano pki/web3check support

❓ Context

  • JIRA or GitHub link: [NO-ISSUE]
  • Feature:

✅ Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@mbertin-ledger mbertin-ledger requested a review from a team as a code owner January 8, 2025 16:35
@vercel Vercel
Copy link

vercel bot commented Jan 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 1:14pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
doc-device-management-kit ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 1:14pm

@mbertin-ledger mbertin-ledger force-pushed the feature/workshop_blockaid branch from 1ad50b5 to 058099e Compare January 9, 2025 13:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025 •
edited
Loading

Fails
🚫

Please fix the PR branch name to match the convention, see CONTRIBUTING.md.

Wrong branch name: feature/workshop_blockaid

ℹ️ Regex to match: /^(feature|feat|bugfix|bug|hotfix|fix|support|chore|core|doc|refacto|refactor)\/((dsdk)-[0-9]+|no-issue|issue-[0-9]+)-.+/i

  • Rules:
    • Must start with a type (feature, feat, bugfix, bug, hotfix, fix, support, chore, core, doc, refacto, refactor)
    • Followed by a SLASH ("/")
    • Followed by a JIRA issue number (DSDK-1234) or "no-issue" or "issue-1234" if fixing a Github issue
    • Followed by a DASH ("-")
    • Followed by a description

ℹ️ Example: feat/dsdk-1234-my-feature
Messages
⚠️ No changeset file found. Please make sure this is intended or add a changeset file.

Generated by 🚫 dangerJS against 4b7fb22

@aussedatlo aussedatlo force-pushed the feature/workshop_blockaid branch from 058099e to 89bca81 Compare January 24, 2025 09:25
@aussedatlo aussedatlo changed the title Feature/workshop blockaid ✨ (signer-eth) [NO-ISSUE]: Add nano pki/web3check support Jan 27, 2025
@aussedatlo aussedatlo force-pushed the feature/workshop_blockaid branch from f755584 to 4b7fb22 Compare January 27, 2025 13:10
@aussedatlo aussedatlo self-assigned this Jan 27, 2025
@aussedatlo
Copy link
Contributor

Wrong branch name, closing. See #639

@aussedatlo aussedatlo closed this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aussedatlo aussedatlo

@mbertin-ledger mbertin-ledger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbertin-ledger @aussedatlo