Skip to content

Commit

Permalink
chore: update upload/download actions to v4
Browse files Browse the repository at this point in the history
  • Loading branch information
valpinkman committed Apr 8, 2024
1 parent 305cc61 commit 295bd93
Show file tree
Hide file tree
Showing 22 changed files with 81 additions and 79 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/bot-portfolio-report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
shell: bash

- name: upload reports
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: reports
path: libs/ledger-live-common/reports
2 changes: 1 addition & 1 deletion .github/workflows/bot-transfer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
timeout-minutes: 200
- name: upload logs
if: failure() || success()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: bot-transfer.txt
path: bot-transfer.txt
8 changes: 4 additions & 4 deletions .github/workflows/build-desktop-external.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,19 +81,19 @@ jobs:
echo "${{matrix.os}}=${{steps.build-app.outcome}}" >> $GITHUB_OUTPUT
- name: Upload linux app
if: matrix.os == 'ubuntu-latest'
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ steps.build-desktop.outputs.version }}-linux-x86_64.AppImage
path: ${{ github.workspace }}/apps/ledger-live-desktop/dist/${{ steps.build-desktop.outputs.name }}-${{ steps.build-desktop.outputs.version }}-linux-x86_64.AppImage
- name: Upload macOS app
if: matrix.os == 'macos-latest'
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ steps.build-desktop.outputs.version }}-mac.dmg
path: ${{ github.workspace }}/apps/ledger-live-desktop/dist/${{ steps.build-desktop.outputs.name }}-${{ steps.build-desktop.outputs.version }}-mac.dmg
- name: Upload windows
if: matrix.os == 'windows-latest'
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ steps.build-desktop.outputs.version }}-win-x64.exe
path: ${{ github.workspace }}/apps/ledger-live-desktop/dist/${{ steps.build-desktop.outputs.name }}-${{ steps.build-desktop.outputs.version }}-win-x64.exe
Expand Down Expand Up @@ -188,7 +188,7 @@ jobs:
summary,
}
fs.writeFileSync("summary.json", JSON.stringify(data), "utf-8");
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
name: Upload output
with:
path: ${{ github.workspace }}/summary.json
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/build-desktop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,13 +100,13 @@ jobs:
GENERATE_METAFILES: 1

- name: Upload ${{ matrix.config.name }} app
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ steps.build-desktop.outputs.version }}-${{ matrix.config.image }}
path: ${{ github.workspace }}/apps/ledger-live-desktop/dist/${{ steps.build-desktop.outputs.name }}-${{ steps.build-desktop.outputs.version }}-${{ matrix.config.image }}

- name: Upload bundle metafiles
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ !cancelled() }}
with:
name: ${{ matrix.config.name }}-js-bundle-metafiles
Expand Down Expand Up @@ -134,15 +134,15 @@ jobs:
app_id: ${{ secrets.GH_BOT_APP_ID }}
private_key: ${{ secrets.GH_BOT_PRIVATE_KEY }}

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: linux-js-bundle-metafiles
path: linux-js-bundle-metafiles
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: win-js-bundle-metafiles
path: win-js-bundle-metafiles
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: mac-js-bundle-metafiles
path: mac-js-bundle-metafiles
Expand Down Expand Up @@ -175,7 +175,7 @@ jobs:
prNumber: ${{ inputs.prNumber }}
mode: desktop

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
name: Upload output
with:
path: ${{ github.workspace }}/summary.json
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build-mobile-external.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
with:
path: ${{ github.workspace }}/apps/ledger-live-mobile
- name: upload Android app
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ steps.post-version.outputs.version }}-release
path: ${{ github.workspace }}/apps/ledger-live-mobile/android/app/build/outputs/apk/release
Expand Down Expand Up @@ -201,7 +201,7 @@ jobs:
}],
}
fs.writeFileSync("summary.json", JSON.stringify(output), "utf-8");
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
name: upload output
with:
path: ${{ github.workspace }}/summary.json
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/build-mobile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ jobs:
with:
path: ${{ github.workspace }}/apps/ledger-live-mobile
- name: upload Android app
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ steps.post-version.outputs.version }}-release
path: ${{ github.workspace }}/apps/ledger-live-mobile/android/app/build/outputs/apk/stagingRelease
Expand Down Expand Up @@ -134,7 +134,7 @@ jobs:
pnpm mobile bundle:android:prod
pnpm mobile gen-metafile
- name: Upload mobile metafile
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: mobile.metafile.json
path: ${{ github.workspace }}/apps/ledger-live-mobile/mobile.metafile.json
Expand All @@ -154,7 +154,7 @@ jobs:
with:
ref: ${{ inputs.ref || github.sha }}
- name: download mobile metafile
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: mobile.metafile.json
- uses: LedgerHQ/ledger-live/tools/actions/build-checks@develop
Expand Down Expand Up @@ -256,7 +256,7 @@ jobs:
}],
}
fs.writeFileSync("summary.json", JSON.stringify(output), "utf-8");
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
name: upload output
with:
path: ${{ github.workspace }}/summary.json
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/commitlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
run: |
set -o pipefail
pnpm commitlint --from ${{ inputs.from && format('origin/{0}', inputs.from) || 'HEAD^1' }} 2>&1 | tee commitlint.out
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
name: upload commitlint output
if: ${{ !cancelled() }}
with:
Expand All @@ -56,7 +56,7 @@ jobs:
if: ${{ !cancelled() }}
steps:
- name: download commitlint output
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: commitlint
- uses: actions/github-script@v6
Expand Down Expand Up @@ -99,7 +99,7 @@ jobs:
}
fs.writeFileSync("summary.json", JSON.stringify(output), "utf-8");
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
name: upload output
with:
path: ${{ github.workspace }}/summary.json
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/gate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
const fs = require("fs");
const affected = ${{ steps.affected.outputs.affected }};
fs.writeFileSync("affected.json", JSON.stringify(affected), "utf-8");
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: affected.json
path: affected.json
Expand All @@ -77,7 +77,7 @@ jobs:
is_fork: ${{ env.is_fork }},
ref: "${{ env.ref }}"
}), "utf-8");
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: pr_metadata.json
path: pr_metadata.json
2 changes: 1 addition & 1 deletion .github/workflows/generate-screenshots.yml
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ jobs:
body
});
}
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
name: upload summary
with:
name: summary.json
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/regen-doc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ jobs:
@${{ inputs.login }}: the documentation is already up to date.`;
fs.writeFileSync("summary.txt", body, "utf8");
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: ${{ !cancelled() }}
name: upload summary
with:
Expand Down Expand Up @@ -161,7 +161,7 @@ jobs:
with:
app_id: ${{ secrets.GH_BOT_APP_ID }}
private_key: ${{ secrets.GH_BOT_PRIVATE_KEY }}
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
name: download summary
with:
name: summary.txt
Expand Down Expand Up @@ -196,7 +196,7 @@ jobs:
body
});
}
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
name: upload summary
with:
name: summary.json
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/regen-pods.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ jobs:
@${{ inputs.login }}: the podfile is already up to date.`;
fs.writeFileSync("summary.txt", body, "utf8");
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: ${{ !cancelled() }}
name: upload summary
with:
Expand Down Expand Up @@ -166,7 +166,7 @@ jobs:
with:
app_id: ${{ secrets.GH_BOT_APP_ID }}
private_key: ${{ secrets.GH_BOT_PRIVATE_KEY }}
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
name: download summary
with:
name: summary.txt
Expand Down Expand Up @@ -201,7 +201,7 @@ jobs:
body
});
}
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
name: upload summary
with:
name: summary.json
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-bridge-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,14 @@ jobs:
pnpm common test-bridge
git diff --exit-code libs/ledger-live-common/src
- name: (On Failure) Upload live-common snapshots and source
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure()
with:
name: ${{ format('live-common-src-{0}', matrix.os) }}
path: |
libs/ledger-live-common/src
- name: (On Failure) Upload logs
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure()
with:
name: logs.txt
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/test-desktop-external.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
run: pnpm desktop prettier:check
- name: typecheck
run: pnpm desktop typecheck
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
name: upload eslint json output
if: ${{ !cancelled() }}
with:
Expand Down Expand Up @@ -127,12 +127,12 @@ jobs:
group-name: ${{ github.ref_name }}-${{ github.run_id }}-${{ github.run_number }}
- name: upload ci suggested screenshots
if: ${{ !cancelled() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: images
path: images-linux.json
- name: Upload playwright test results [On Failure]
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure() && !cancelled()
with:
name: playwright-results-linux
Expand All @@ -144,7 +144,7 @@ jobs:
apps/ledger-live-desktop/tests/artifacts/logs
- name: Upload Allure Report
if: ${{ !cancelled() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: allure-results-linux
path: apps/ledger-live-desktop/allure-results
Expand All @@ -159,11 +159,11 @@ jobs:
ref: ${{ github.ref_name }}
persist-credentials: false
- name: "download linter results"
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: lint
- name: download images artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: images
- name: parse images
Expand Down Expand Up @@ -317,7 +317,7 @@ jobs:
};
fs.writeFileSync("summary.json", JSON.stringify(output), "utf-8");
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
name: upload summary
with:
name: summary.json
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/test-desktop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
run: pnpm desktop prettier:check
- name: typecheck
run: pnpm desktop typecheck
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
name: upload eslint json output
if: ${{ !cancelled() }}
with:
Expand Down Expand Up @@ -146,12 +146,12 @@ jobs:
group-name: ${{ github.ref_name }}-${{ github.run_id }}-${{ github.run_number }}
- name: upload ci suggested screenshots
if: ${{ !cancelled() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: images
path: images-linux.json
- name: Upload playwright test results [On Failure]
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure() && !cancelled()
with:
name: playwright-results-linux
Expand All @@ -164,7 +164,7 @@ jobs:
apps/ledger-live-desktop/tests/artifacts/*.log
- name: Upload Allure Report
if: ${{ !cancelled() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: allure-results-linux
path: apps/ledger-live-desktop/allure-results
Expand All @@ -177,11 +177,11 @@ jobs:
with:
ref: ${{ inputs.ref || github.sha }}
- name: "download linter results"
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: lint
- name: download images artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: images
- name: parse images
Expand Down Expand Up @@ -407,7 +407,7 @@ jobs:
payload-file-path: ${{ github.workspace }}/payload-slack-content.json
env:
SLACK_BOT_TOKEN: ${{ secrets.SLACK_LIVE_CI_BOT_TOKEN }}
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
name: upload summary
with:
name: summary.json
Expand Down
Loading

0 comments on commit 295bd93

Please sign in to comment.