fix: 🔁 device selection after aborted flow

[thesan]

✅ Checklist

• npx changeset was attached.
• Covered by automatic tests.
• Impact of the changes:
  • ...

📝 Description

I'm opened to alternative solutions.

TLDR: I'm not completely satisfied with this solution but I don't see another way which doesn't involve a major refactor.

The issue comes from the current structure of DeviceActionModal which relies on the device prop and result internal state to trigger the drawer. Once result is set the drawer is not supposed to re-opened and since device is not necessary reset something like this doesn't always work:

useEffect(() => {
  if (!device) return () => setResult(null);
}, [device]);

(also it might break some other flow unrelated to ledger sync).

The way I see it selecting a device should imperatively trigger the device interaction. But this component is used this way everywhere else there is a device interaction on LLM.

Screen.Recording.2024-09-09.at.13.23.50.mov

❓ Context

• LIVE-13937

---

🧐 Checklist for the PR Reviewers

• The code aligns with the requirements described in the linked JIRA or GitHub issue.
• The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
• There are no undocumented trade-offs, technical debt, or maintainability issues.
• The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
• Any new dependencies have been justified and documented.
• Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
ledger-live-docs	⬜️ Ignored (Inspect)	Visit Preview		Sep 10, 2024 9:08am
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview		Sep 10, 2024 9:08am
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview		Sep 10, 2024 9:08am
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview		Sep 10, 2024 9:08am
web-tools	⬜️ Ignored (Inspect)	Visit Preview		Sep 10, 2024 9:08am