Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow gasLimit field to be disabled #7784

Merged
merged 2 commits into from
Sep 13, 2024
Merged

feat: allow gasLimit field to be disabled #7784

merged 2 commits into from
Sep 13, 2024

Conversation

CremaFR
Copy link
Member

@CremaFR CremaFR commented Sep 10, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

allow gasLimit field edit button to be hidden as we do not want our user to update this during a SWAP

result for swap

Screenshot 2024-09-10 at 09 53 41

❓ Context

- JIRA or GitHub link:


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@CremaFR CremaFR requested a review from a team as a code owner September 10, 2024 08:18
@CremaFR CremaFR requested a review from a team September 10, 2024 08:18
@CremaFR CremaFR requested a review from a team as a code owner September 10, 2024 08:18
Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
ledger-live-github-bot βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 13, 2024 7:32am
web-tools ❌ Failed (Inspect) Sep 13, 2024 7:32am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 7:32am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 7:32am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 7:32am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Sep 10, 2024
@CremaFR CremaFR merged commit 0bad0cb into develop Sep 13, 2024
41 of 42 checks passed
@CremaFR CremaFR deleted the feat/LIVE-14012 branch September 13, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants