Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ock app on inactive/backgournd state of app (except deeplinking) #8623

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

fix: ock app on inactive/backgournd state of app (except deeplinking) #8623

wants to merge 1 commit into from

Conversation

themooneer
Copy link
Contributor

@themooneer themooneer commented Dec 6, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

app_lock_on_bg_ok.mov

Note: the blurr behaviour when swipe up the app on ios is already in another error ticket.

❓ Context

  • JIRA or GitHub link:

https://ledgerhq.atlassian.net/browse/LIVE-15065

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@themooneer themooneer requested a review from a team as a code owner December 6, 2024 07:24
@vercel Vercel
Copy link

vercel bot commented Dec 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 8:49am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 8:49am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 8:49am
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 8:49am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Dec 6, 2024
KVNLS
KVNLS reviewed Dec 6, 2024
View reviewed changes
apps/ledger-live-mobile/src/context/AuthPass/index.tsx
Platform.OS === "ios" ? appState === "background" : appState.match(/inactive|background/);

return isAppInBackground;
return appState.match(/inactive|background/);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we don't create other issues here? When I look at the comment it seems that it was done intentionally

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've already seen that the development done before, is related to bypass the lock on deeplink redirection context which i've tested it (in the video) so, i don't think that it will cause another issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, can you double-check when we open the camera please? I have seen issues related to it in the past. Such as scan a QR Code for Ledger Sync or scan a QR Code for the send flow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hummmm nice recommendation ! i'll do it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when i tested it the first time, it prompt me a camera permission, then when i accept it , the phone is locked. After that the access to the camera wasn't blocking , no issues, but i think it's problematic for BLE pairing for the first time (ios prompt make the app state inactif)
I should reconsider this implementation and look for another status.
Thank you very much for this instructive recommendation @KVNLS

@themooneer themooneer marked this pull request as draft December 6, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KVNLS KVNLS KVNLS left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@themooneer themooneer

Labels
mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@themooneer @KVNLS