📌 hw-ledger-key-ring-protocol - pin tiny-secp256k1 version to 1.1.7 #8653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
cgrellard-ledger
force-pushed
the
bugfix/ecc-library-invalid
branch
from
29e595f to
abd446a
Compare
thesan
reviewed
Dec 11, 2024
There was a problem hiding this comment.
@ledgerhq/hw-app-btc depend on [email protected] shouldn't we have the same version for both packages ?
mcayuelas-ledger
approved these changes
Dec 11, 2024
|
I guess this is what causes:
|
thesan
reviewed
Dec 11, 2024
cgrellard-ledger
force-pushed
the
bugfix/ecc-library-invalid
branch
from
abd446a to
fbff5e4
Compare
thesan
reviewed
Dec 11, 2024
| @@ -24,7 +24,7 @@ | |||
| "bip32": "^4.0.0", | |||
| "secp256k1": "^5.0.0", | |||
| "create-hmac": "^1.1.7", | |||
| "tiny-secp256k1": "1" | |||
| "tiny-secp256k1": "1.1.7" | |||
There was a problem hiding this comment.
Still I think it would be best to also update the one in libs/ledgerjs/packages/hw-app-btc/package.json. First to avoid duplicating the lib but also I'm struggling building LLD with newer versions of electron builder because of this package (for the app ASAR integrity check) so I would prefer having only one to worry about!
thesan
approved these changes
Dec 11, 2024
cgrellard-ledger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
It may fix the following Sentry error : https://ledger.sentry.io/issues/6115989813/?alert_rule_id=15006706&alert_type=issue¬ification_uuid=27e565f1-802b-4dc5-88a0-906844100a0f&project=6505213&referrer=slack
❓ Context
🧐 Checklist for the PR Reviewers