Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Banner to warn users about the migration #9344

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Canestin
Copy link
Contributor

@Canestin Canestin commented Feb 26, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 0:55am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 0:55am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 0:55am
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 0:55am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Feb 26, 2025
@Canestin Canestin changed the title add config Add Banner to warn users about the fantom migration Feb 26, 2025
@Canestin Canestin changed the title Add Banner to warn users about the fantom migration Add Banner to warn users about the migration Feb 26, 2025
@Canestin Canestin marked this pull request as ready for review February 28, 2025 09:24
@Canestin Canestin requested review from a team as code owners February 28, 2025 09:24
@live-github-bot live-github-bot bot added the translations Translation files have been touched label Feb 28, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required β‰₯ 80%)
33.6% Duplication on New Code (required ≀ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants