Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VG-3617: Fix some weird crash in wd integration tests #858

Merged
merged 4 commits into from
Mar 2, 2022
Merged

VG-3617: Fix some weird crash in wd integration tests #858

merged 4 commits into from
Mar 2, 2022

Conversation

jcoatelen-ledger
Copy link
Contributor

@jcoatelen-ledger jcoatelen-ledger commented Feb 28, 2022 •
edited
Loading

Changes:

  • Fix a very specific weird crash that happens when loading the libcore from the Java runtime. It happens when initializing std::regex in static variables.
  • Fix btc transaction parsing when the explorer returns fees as string values (not integer).
  • Fix possible memory leak in Base58 (Potential memory leak #859)
  • Bump patch version to 4.1.6

References:

@jcoatelen-ledger jcoatelen-ledger changed the title try to fix some weird crash in wd integration tests VG-3617: Fix some weird crash in wd integration tests Feb 28, 2022
viktorb-ledger
viktorb-ledger reviewed Mar 1, 2022
View reviewed changes
Copy link
Contributor

@viktorb-ledger viktorb-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried lazy init of static variables on the first use?

@jcoatelen-ledger
Copy link
Contributor Author

Have you tried lazy init of static variables on the first use?

I discussed this possibility with @twilgenbus-ledger I plan to test this later today ;)

@jcoatelen-ledger
fix: weird crash in wd integration tests when loading libcore.
e195528 
The fix is to avoid using std::regex constructor of global static variables
using lazy initialization of static variables. The crash happens when the
WD tries to load the libcore and static regex variable are being
initialized. It looks like the locale is not yet correctly defined and the
regex constructor does not accept this case.
@jcoatelen-ledger
fix: btc transaction incorrect parsing when values are string
f6964d9 
Handle string type for some fields in BTC transaction returned
by explorers.
@jcoatelen-ledger
fix: possible memory leak in Base58
18034b2
@jcoatelen-ledger
ci: bump patch version
618cc43
@jcoatelen-ledger jcoatelen-ledger merged commit 401573f into release/4.1.0 Mar 2, 2022
@jcoatelen-ledger jcoatelen-ledger deleted the fix-crash-wd-integration-tests branch March 2, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktorb-ledger viktorb-ledger viktorb-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcoatelen-ledger @viktorb-ledger