Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taproot address support implemented #144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

taproot address support implemented #144

wants to merge 1 commit into from

Conversation

vsenkiv-ledger
Copy link

@vsenkiv-ledger vsenkiv-ledger commented Oct 11, 2022 •
edited
Loading

The goal of this PR is to implement possibility to scan taproot addresses.
Currently works only for mainnet.

@korchmar korchmar deleted the implement_scan_of_taproot_adresses branch October 11, 2022 14:23
@korchmar korchmar restored the implement_scan_of_taproot_adresses branch October 11, 2022 14:37
twilgenbus-ledger
twilgenbus-ledger reviewed Oct 11, 2022
View reviewed changes
Copy link

@twilgenbus-ledger twilgenbus-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

  • If it works only for mainnet, what happens when used on testnet?

src/actions/deriveAddresses.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
src/actions/deriveAddresses.ts Show resolved Hide resolved
@vsenkiv-ledger
Copy link
Author

Great work!

  • If it works only for mainnet, what happens when used on testnet?
    no crash, no error is thrown, but for test I used testnet taproot xpub which has no transactions, so I'm just getting 0 balance and 0 transactions what it expected but for complete test taproot testnet account with transactions is neeeded, creating taproot transactions would took more time and my final goal is to implement cardano scan, so at the moment taproot mainnet confirmed, testnet - not tested fully, just that no errors.

jcoatelen-ledger
jcoatelen-ledger approved these changes Oct 12, 2022
View reviewed changes
Copy link

@jcoatelen-ledger jcoatelen-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavlogs
Copy link
Contributor

pavlogs commented Dec 1, 2022

To pass all checks you should rebase on main and update dependencies if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twilgenbus-ledger twilgenbus-ledger twilgenbus-ledger left review comments

@jcoatelen-ledger jcoatelen-ledger jcoatelen-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsenkiv-ledger @pavlogs @twilgenbus-ledger @jcoatelen-ledger