Refactor #89 UserUseCase 분리 및 리프레시 토큰 수정 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
huncozyboy
reviewed
Dec 6, 2024
| import leets.weeth.global.auth.jwt.application.dto.JwtDto; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| import static leets.weeth.domain.user.application.dto.request.UserRequestDto.refreshRequest; | ||
|
|
||
| public interface UserManageUseCase { |
There was a problem hiding this comment.
고생많으셨습니다 어드민 페이지에서 관리할 수 있는 정보(회원조회, 가입 승인, 유저 추방, 관리자 승격 + 강등, 다음 기수도 진행, 비번 초기화)들은 PR에 적어주셨듯이 어드민 기준이기 때문에 userManageUseCase라는 이름과 별도로 구성한 목적에 맞다고 판단이 드는데, 동아리 멤버 전체 조회라던지 내 정보와 관련된 부분도 userManageUseCase로 들어가는 것은 추가적인 고민이 필요해보입니다
There was a problem hiding this comment.
저도 조회같은 부분은 manage 말고 UserUseCase에 들어가야 한다고 생각합니다
There was a problem hiding this comment.
그러면 admin 관련한 메서드만 Manage에 넣도록 하겟습니당
jj0526
approved these changes
Dec 6, 2024
| import leets.weeth.global.auth.jwt.application.dto.JwtDto; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| import static leets.weeth.domain.user.application.dto.request.UserRequestDto.refreshRequest; | ||
|
|
||
| public interface UserManageUseCase { |
There was a problem hiding this comment.
저도 조회같은 부분은 manage 말고 UserUseCase에 들어가야 한다고 생각합니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 내용
PR 세부사항
관련 스크린샷
주의사항
X
체크 리스트