Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yezzan9
reviewed
Dec 19, 2024
src/pages/Landing.tsx
Outdated
| const navigate = useNavigate(); | ||
| const CLIENT_ID = import.meta.env.VITE_KAKAO_CLIENT_ID; | ||
| const REDIREC_URI = import.meta.env.VITE_KAKAO_REDIRECT_URI; |
There was a problem hiding this comment.
이럴수가! 꼼꼼한 검토 감사합니다
yezzan9
approved these changes
Dec 19, 2024
yezzan9
approved these changes
Dec 22, 2024
#310 feat: 출석 기수 컴포넌트 UI
…l/Weeth-FE into feat#301/로그인-로직-변경
One-HyeWon
commented
Feb 2, 2025
yezzan9
reviewed
Feb 3, 2025
|
여기 파란색 글자 왼쪽만 여백이 넓은 것 같은데 확인 부탁드려요! |
헉!!!!!!!!! 매의 눈 감사합니다,,,,,,,,,,,,, p 태그 때문인지 띄어쓰기가 안 먹혀서 공백 문자를 넣었더니 기준이 다른가봐요! 다른 방법을 찾아보도록 하겠습니다! |
dalzzy
approved these changes
Feb 4, 2025
| flex-direction: column; | ||
| width: 370px; | ||
| max-width: 370px; | ||
| padding-top: 0; |
There was a problem hiding this comment.
여기 설정된 padding-top: 0 도 제거하는 걸 깜빡하신거겠죠??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 무슨 이유로 코드를 변경했나요?
기존 자체 로그인에서 카카오 로그인으로 로직을 변경하였습니다.
2. 어떤 위험이나 장애를 발견했나요?
신규유저와 기존유저의 구분이 필요합니다.
신규 회원가입 클릭시 카카오 로그인으로 연동되는 것은 동일하나, 이후 리다이렉트 되는 페이지가 구분 되어야 합니다.
3. 관련 스크린샷을 첨부해주세요.
4. 완료 사항
5. 추가 사항
close #301