-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Misc Mappings #283
base: v2
Are you sure you want to change the base?
Update Misc Mappings #283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a conflicts around BlockPos.BITS_X
, resolve it and I'll take a look again.
Overall your pull request looks good to me.
FIELD field_0_5760 BIT_SHIFT_Y I | ||
FIELD field_0_5761 BIT_SHIFT_X I | ||
FIELD field_0_5763 BITS_Y J | ||
FIELD field_10973 BITS_X J |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In which version did you map this? I know for sure it's supposed to be BITS_Z
for 1.14-Snapshots+. I hope it's not a mismatch on intermediary side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In which version did you map this? I know for sure it's supposed to be
BITS_Z
for 1.14-Snapshots+. I hope it's not a mismatch on intermediary side.
I mapped this on 1.8.9. SIZE_BITS_X and SIZE_BITS_Z have the same value, so therefore BITS_X and BITS_Z have the same value.
I named it after whichever SIZE_BITS variable it used, but also in BlockPos#fromLong it uses
public static BlockPos fromLong(long packedPos) {
int i = (int)(packedPos << 64 - BIT_SHIFT_X - SIZE_BITS_X >> 64 - SIZE_BITS_X);
int j = (int)(packedPos << 64 - BIT_SHIFT_Y - SIZE_BITS_Y >> 64 - SIZE_BITS_Y);
int k = (int)(packedPos << 64 - SIZE_BITS_Z >> 64 - SIZE_BITS_Z);
return new BlockPos(i, j, k);
}
I am not too sure what is correct for those mappings.
@@ -15,12 +18,17 @@ CLASS net/minecraft/class_2338 net/minecraft/util/math/BlockPos | |||
FIELD field_10980 ORIGIN Lnet/minecraft/class_2338; | |||
COMMENT The block position which x, y, and z values are all zero. | |||
FIELD field_10981 BIT_SHIFT_X I | |||
FIELD field_10982 BITS_Z J |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be BIT_MASK_CHUNK_SECTION
in 1.14-Snapshots according to yarn mappings.
No description provided.