Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend updates #36

Merged
merged 4 commits into from
Feb 10, 2024
Merged

frontend updates #36

merged 4 commits into from
Feb 10, 2024

Conversation

melbaa
Copy link
Contributor

@melbaa melbaa commented Feb 10, 2024

build

docker + compose

  • allow selecting dev or prod builds by including the docker-compose-dev.yml
    docker compose -f docker-compose.yml -f docker-compose-dev.yml ...
  • sets up some bind mounts for the source code

node + angular

  • update node to v20, angular to v17, chartjs to v4, ng-multiselect-dropdown to v1, typescript to v5
  • add the npm builddev cmd and angular development config. this enables angular development mode, which makes the browser devtools extension usable

code

  • the multi_select input component is custom made and broke due to migration. It was using angular internals that no longer exist; commented it more and fixed it to work similar to the orig. impl. but it's not well made. It's the cause of search and select all options disappear from abilities selection frame when you change segment. #23
  • the main multi_select dependency, ng-multiselect-dropdown, is also broken by default in the never version. It wasn't hiding the extra selections, had to modify the scss to fix.
  • the chartjs API has changed a little, had to fix related code. In the process commented out some tooltip code, no clue where those show up.
  • random syntax and style fixes due to new angular/node/typescript versions

Copy link
Collaborator

@YamaYAML YamaYAML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful work, tested extensively in preprod. Prod is being migrated to new hardware on this codebase.

@YamaYAML YamaYAML merged commit fa02532 into main Feb 10, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants