Fix for cffi warning (continue)

Legrandin · Oct 17, 2016 · 9b12b8d · 9b12b8d
1 parent 696d164
commit 9b12b8d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/lib/Crypto/Cipher/_mode_gcm.py b/lib/Crypto/Cipher/_mode_gcm.py
@@ -82,9 +82,8 @@ def __init__(self, subkey):
         self._exp_key = SmartPointer(self._exp_key.get(),
                                      _raw_galois_lib.ghash_destroy)
 
+        # create_string_buffer always returns a string of zeroes
         self._last_y = create_string_buffer(16)
-        for i in xrange(16):
-            self._last_y[i] = bchr(0)
 
     def update(self, block_data):
         assert len(block_data) % 16 == 0

diff --git a/lib/Crypto/Util/_raw_api.py b/lib/Crypto/Util/_raw_api.py
@@ -63,7 +63,7 @@ def c_size_t(x):
         return x
 
     def create_string_buffer(size):
-        """Allocate the given amount of bytes"""
+        """Allocate the given amount of bytes (initially set to 0)"""
         return ffi.new("uint8_t[]", size)
 
     def get_c_string(c_string):
@@ -86,7 +86,7 @@ def get(self):
         def address_of(self):
             return self._pp
 
-    Array = ffi.new("char[1]").__class__.__bases__
+    Array = ffi.new("uint8_t[1]").__class__.__bases__
 
     backend = "cffi"