Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing argument to function simulate_one_avatar #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hih0124
Copy link

@hih0124 hih0124 commented Jul 7, 2024

Reason for Change

  • The "simulate_one_avatar" function was causing errors due to an incorrect argument.
    (missing argument & incorrect argument type)

Changes Made

  • Added the current_page argument to the reaction_to_recommended_items function.
  • Changed the movies_on_page parameter type from list to string in the "simulate_one_avatar" function.
  • This correction ensures the function operates as expected.

Testing

  • This correction ensures the function operates as expected.

@LehengTHU
Copy link
Owner

Thanks for your kind notification! Actually, this function was not adopted in our experiments. The function we used is "async_simulate_one_avatar", which enables us to run the simulation simultaneously in an async paradigm. However, I will check the errors you mentioned in the "simulate_one_avatar".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants