Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add more runtimes/versions to CI #98

Merged
merged 9 commits into from
Jul 3, 2024
Merged

chore: Add more runtimes/versions to CI #98

merged 9 commits into from
Jul 3, 2024

Conversation

LekoArts
Copy link
Owner

@LekoArts LekoArts commented Jul 3, 2024

Description

In preparation for #22 I wanted to have better integration testing. So this PR adds the following things:

  • Run unit tests both with Node 18 and Node 20
  • Run integration tests with npm, pnpm, yarn, and bun
  • Assert that secco sees correct pm in destination package.json
  • Remodel underlying test setup so that adding a new fixture for workspaces will be easier

Checklist

  • pnpm run test runs as expected.
  • pnpm run build runs as expected.
  • (If applicable) Documentation has been updated

Copy link

changeset-bot bot commented Jul 3, 2024

⚠️ No Changeset found

Latest commit: 15f9320

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for secco-cli canceled.

Name Link
🔨 Latest commit 15f9320
🔍 Latest deploy log https://app.netlify.com/sites/secco-cli/deploys/668537b322a620000892ed32

Copy link
Contributor

github-actions bot commented Jul 3, 2024

Size Change: 0 B 🆕

Total Size: 0 B

compressed-size-action

@LekoArts LekoArts marked this pull request as ready for review July 3, 2024 11:42
@LekoArts LekoArts merged commit 3020434 into main Jul 3, 2024
12 checks passed
@LekoArts LekoArts deleted the ci/diff-runtimes branch July 3, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant