Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat ✨: Add controller text support #1

Merged
merged 77 commits into from
Dec 7, 2024
Merged

feat ✨: Add controller text support #1

merged 77 commits into from
Dec 7, 2024

Conversation

PA055
Copy link
Contributor

@PA055 PA055 commented May 22, 2024 •
edited by github-actions bot
Loading

Summary

creates an abstract text screen that gets polled for updates and updates the text on the controller or rumbles

Motivation

text on the controller is really the only way to give feedback to the driver during a match, rumbles are nice too

Test Plan

WIP

Download the template for this pull request:

Note

This is auto generated from Add Template to Pull Request

curl -o [email protected]+85db01.zip https://nightly.link/LemLib/Gamepad/actions/artifacts/2288685603.zip;
pros c fetch [email protected]+85db01.zip;
pros c apply [email protected]+85db01;
rm [email protected]+85db01.zip;

@ion098 ion098 self-requested a review May 22, 2024 00:34
ion098
ion098 requested changes May 22, 2024
View reviewed changes
include/gamepad/controller.hpp Outdated Show resolved Hide resolved
include/gamepad/controller.hpp Outdated Show resolved Hide resolved
include/gamepad/controller.hpp Outdated Show resolved Hide resolved
include/gamepad/controller.hpp Show resolved Hide resolved
src/gamepad/controller.cpp Outdated Show resolved Hide resolved
src/gamepad/controller.cpp Outdated Show resolved Hide resolved
src/gamepad/controller.cpp Outdated Show resolved Hide resolved
src/gamepad/controller.cpp Outdated Show resolved Hide resolved
src/gamepad/controller.cpp Outdated Show resolved Hide resolved
include/gamepad/controller.hpp Outdated Show resolved Hide resolved
ion098
ion098 previously approved these changes May 23, 2024
View reviewed changes
@ion098 ion098 requested a review from Aang099 May 23, 2024 16:51
ion098
ion098 reviewed May 24, 2024
View reviewed changes
src/gamepad/controller.cpp Outdated Show resolved Hide resolved
@ion098 ion098 dismissed their stale review June 2, 2024 19:13

API needs reworking

@ion098 ion098 marked this pull request as draft June 2, 2024 19:13
@PA055 PA055 marked this pull request as ready for review June 4, 2024 22:12
PA055 and others added 13 commits October 11, 2024 20:58
@PA055
fix: 🐛 fix nullpointers getting turned into empty strings
d06277a
@PA055
fix: 🐛 multiples line changes not registering
c357038 
needed to return after writing to a line, and also removed debug statements
@PA055
fix: 🐛 screen not being cleared first print
a1c3f15 
i initialized screen cleared to the wrong value, and i forgot to clear it
@PA055
chore: 💩 get_priority is the problem, idk why
dd06cda
@PA055
test: ✨ the alerts are kinda working
82c0937 
the logic in the abstract screen seems weird based on the behavior
@PA055
fix: 🐛 repeated alert rumbles
b1e4093 
rumbles in alerts were being repeated constantly for the duration of the alert, i had to clear it after 1 iteration
@PA055
chore: 🔥 remove debug prints
aa4904d
@PA055
chore: 🔥 remove debug prints
993960f
@PA055
Merge branch 'text' of https://github.com/PA055/Gamepad into text
5606ac5
@PA055
refactor: 🎨 run clang-format
a5f29cb
@PA055
feat: ✨ disconnect/reconnect logic
85be74a 
still bugged, debug prints are included however commented out
@PA055
test line clearing
6812d03
@ion098
Merge branch 'main' into text
9c16e78
@ion098 ion098 marked this pull request as ready for review November 4, 2024 16:50
@ion098 ion098 requested a review from SizzinSeal November 12, 2024 23:28
SizzinSeal
SizzinSeal previously requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@SizzinSeal SizzinSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit rough around the edges but mostly fine

include/gamepad/gamepad.hpp Outdated Show resolved Hide resolved
include/gamepad/gamepad.hpp Outdated Show resolved Hide resolved
include/gamepad/gamepad.hpp Outdated Show resolved Hide resolved
include/gamepad/gamepad.hpp Outdated Show resolved Hide resolved
include/gamepad/screens/abstractScreen.hpp Outdated Show resolved Hide resolved
src/gamepad/gamepad.cpp Outdated Show resolved Hide resolved
src/gamepad/gamepad.cpp Outdated Show resolved Hide resolved
src/gamepad/gamepad.cpp Outdated Show resolved Hide resolved
src/gamepad/screens/defaultScreen.cpp Show resolved Hide resolved
src/main.cpp Outdated Show resolved Hide resolved
ion098
ion098 requested changes Nov 14, 2024
View reviewed changes
debug.log Outdated Show resolved Hide resolved
include/gamepad/gamepad.hpp Outdated Show resolved Hide resolved
include/gamepad/gamepad.hpp Outdated Show resolved Hide resolved
src/gamepad/gamepad.cpp Show resolved Hide resolved
@ion098 ion098 requested review from SizzinSeal and ion098 November 21, 2024 17:20
ion098
ion098 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@ion098 ion098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this just needs merge conflicts to be fixed

@ion098 ion098 dismissed SizzinSeal’s stale review December 7, 2024 15:36

Changes addressed

@ion098 ion098 merged commit 4afd080 into LemLib:main Dec 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ion098 ion098 ion098 approved these changes

@Aang099 Aang099 Awaiting requested review from Aang099

@SizzinSeal SizzinSeal Awaiting requested review from SizzinSeal

Assignees
No one assigned
Labels
enhancement New feature or request needs testing This PR/bug report needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PA055 @SizzinSeal @ion098