Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Rename stuff and split files #19

Merged
merged 5 commits into from
Sep 25, 2024
Merged

♻️ Rename stuff and split files #19

merged 5 commits into from
Sep 25, 2024

Conversation

ion098
Copy link
Collaborator

@ion098 ion098 commented Sep 25, 2024

  • Rename Gamepad namespace to gamepad (maybe consider gpad as an alias?)
  • Rename Controller class to Gamepad
  • Split the Button class into its own source and header files, seperate from Controller's files

@ion098 ion098 requested review from SizzinSeal and Aang099 and removed request for SizzinSeal September 25, 2024 19:01
SizzinSeal
SizzinSeal approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@SizzinSeal SizzinSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ion098 ion098 merged commit b19f622 into main Sep 25, 2024
3 checks passed
@SizzinSeal SizzinSeal deleted the refactor/rename-and-split branch September 25, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SizzinSeal SizzinSeal SizzinSeal approved these changes

@Aang099 Aang099 Awaiting requested review from Aang099

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ion098 @SizzinSeal