helper now formats message; fix compilation errors

include/lemlog/logger/logger.hpp

@@ -1,5 +1,6 @@
 #pragma once
 
+#include "fmtlib/core.h"
 #include <string>
 
 namespace logger {
@@ -87,6 +88,21 @@ enum class Level {
     ERROR,
 };
 
+/**
+ * @brief log a message with a level and topic
+ *
+ * Messages with a logging level of DEBUG must have the topic whitelisted,
+ * while all other messages are sent by default unless the topic is blacklisted
+ *
+ * @param level the level of the message, e.g INFO
+ * @param topic the topic of the message, e.g "lemlib/motions/boomerang"
+ * @param format the pre-formatted message, e.g. "Hello, {}!"
+ * @param args the arguments to be formatted into the message, e.g. "world"
+ *
+ * @tparam Args the types of the arguments to be formatted into the message
+ */
+static void log(Level level, std::string topic, std::string message);
+
 /**
  * @brief Logger Helper class. Used to send messages to all sinks
  *
@@ -108,6 +124,7 @@ class Helper {
          * @endcode
          */
         Helper(std::string topic);
+
         /**
          * @brief Send a message to all sinks
          *
@@ -127,7 +144,11 @@ class Helper {
          */
         template <typename... Args>
         void log(Level level, const std::string& format, Args&&... args) {
-            logger::log(level, m_topic, format, args...);
+            // format the message into a string using the provided arguments
+            std::string message =
+                fmt::format(format, std::forward<Args>(args)...);
+
+            logger::log(level, m_topic, message);
         }
     private:
         const std::string m_topic;

src/lemlog/logger/logger.cpp

@@ -17,24 +17,7 @@ void addBlacklist(std::string s) { blacklist.push_back(s); }
 
 void removeBlacklist(std::string s) { blacklist.remove(s); }
 
-/**
- * @brief log a message with a level and topic
- *
- * Messages with a logging level of DEBUG must have the topic whitelisted,
- * while all other messages are sent by default unless the topic is blacklisted
- *
- * @param level the level of the message, e.g INFO
- * @param topic the topic of the message, e.g "lemlib/motions/boomerang"
- * @param format the pre-formatted message, e.g. "Hello, {}!"
- * @param args the arguments to be formatted into the message, e.g. "world"
- * 
- * @tparam Args the types of the arguments to be formatted into the message
- */
-template <typename... Args>
-static void log(Level level, std::string topic, std::string& format, Args&&... args) {
-    // format the message into a string using the provided arguments
-    std::string message = fmt::format(format, std::forward<Args>(args)...);
-
+static void log(Level level, std::string topic, std::string message) {
     // is the message a debug message?
     if (level == Level::DEBUG) {
         // is it whitelisted?