♻️ Improved run instruction #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
meisZWFLZ
commented
Jan 2, 2025
meisZWFLZ
commented
- Makes it a little more readable by using heredoc
- Pipes tar.xz to tar to prevent writing it to disk
- Uses brace expansion where possible to shorten
- Don't even write some of the unnecessary files to disk
- Makes it a little more readable by using heredoc - Pipes tar.xz to tar to prevent writing it to disk - Uses brace expansion where possible to shorten - Don't even write some of the unnecessary files to disk
…icency and convert all tar --exclude params to their original rm/find forms.
ABUCKY0
approved these changes
Jan 3, 2025
…redone in runner stage and the packages aren't used in the get-deps stage
ABUCKY0
added a commit
that referenced
this pull request
Jan 3, 2025
* Test Alpine linux (See Jerrylum/pros-build) * Update Dockerfile * Update Dockerfile * Use pipx * Update Dockerfile * Add root/.local/bin to path * Make build.sh in the root folder * Try specifying filename where to copy build.sh to * Update Dockerfile * Update Dockerfile * Change /build.sh to ~/build.sh * Update Dockerfile * Update Dockerfile * add sh and bash for good measure * Update Dockerfile * Put the toolchain on a serious diet * Comment out G++ * forgot to uncomment the path 💀 * add G++ back in * run ldd on each program in the dieted toolchain * try ldd again * Update Dockerfile * Update copied files * Change non-dieted files. * Add libexec to included files * add possibly missing / * Update Dockerfile * Remove extra folder from mkdir * remove -r flag * include arm-none-eabi/lib too * pivot to deleting stuff from the toolchain folder instead of selectively copying stuff. Starting with arm-none-eabi folder * Delete share folder instead * try deleting arm-none-eabi/lib * forgot the folder prefix * delete /lib/gcc/arm-none-eabi/13.3.1/arm and /lib/gcc/arm-none-eabi/13.3.1/thumb * delete all but v7-a+fp in thumb * forgot /arm-none-eabi-toolchain prefix again * remove files in RUN rm -f /arm-none-eabi-toolchain/lib/gcc/arm-none-eabi/13.3.1/* but not folders * Update Dockerfile * Update action.yml to test externally * Update Dockerfile with stages * fix copy from stage * comment out rm command to test stages * add back package installation * Update Dockerfile * refactor to have more stages * Update Dockerfile * Update build-image.yml * Update build-image.yml * Update build-image.yml * Remove line that deletes all 13.3.1 subfiles and subfolders * Diet some more files arm-none-eabi-cpp, arm-none-eabi-gdb, arm-none-eabi-gcc-13.3.1, * Change dieted files to their actual location (misread on my part) * Update Dockerfile * diet some more folders * we cut too much * Update build.sh * Update test.yml * revert back * revert back * Update action.yml * also remove gbd-py from toolchain bin folder * Update Dockerfile * re-add pros-cli * steal additional thumb deleting from jerryio's container * Update Dockerfile labels * Update Dockerfile * Thanks to @Jerrylum * Remove total build script runtime from build.sh as it's confusing * Delete packagelist * Update README.md * Update action.yml with v4.0.0 * remove pruning steps * Update build.sh to use shell instead of bash * remove bash * Restore bash * ♻️ Improved run instruction (#14) * ♻️ Improved run instruction - Makes it a little more readable by using heredoc - Pipes tar.xz to tar to prevent writing it to disk - Uses brace expansion where possible to shorten - Don't even write some of the unnecessary files to disk * split toolchain downloading into seperate RUN command for caching efficency and convert all tar --exclude params to their original rm/find forms. * Fix broken gcc rm command for /bin/arm-none-eabi-gcc-13.3.1 * fix gcc-13.3.1 removal * delete long_toolchain variable * 💄 Remove extra whitespace * remove package installation from get-dependencies since it's already redone in runner stage and the packages aren't used in the get-deps stage --------- Co-authored-by: ABUCKY0 <[email protected]> * Delete commented commands for clarity --------- Co-authored-by: Andrew Curtis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.