erase date extractor as parameter

Lemoncode · Oct 17, 2023 · 64ec177 · 64ec177
1 parent f95266f
commit 64ec177
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/packages/manfred-common/src/doc-parts/experience-section/experience-section.helpers.ts b/packages/manfred-common/src/doc-parts/experience-section/experience-section.helpers.ts
@@ -4,11 +4,11 @@ import { dateExtractor, sortByDate } from '../../helpers';
 
 export const sortRolesByDate = (experience: ExperienceVm): ExperienceVm => ({
   ...experience,
-  roles: sortByDate(experience.roles, dateExtractor) as Role[],
+  roles: sortByDate(experience.roles) as Role[],
 });
 
 export const mapSortedRolesIntoExperience = (experience: ExperienceVm[]): ExperienceVm[] =>
   experience.map(experienceItem => sortRolesByDate(experienceItem));
 
 export const sortExperienceByDate = (experience: ExperienceVm[]): ExperienceVm[] =>
-  sortByDate(experience, dateExtractor) as ExperienceVm[];
+  sortByDate(experience) as ExperienceVm[];
diff --git a/packages/manfred-common/src/doc-parts/studies-section/studies-section.helpers.ts b/packages/manfred-common/src/doc-parts/studies-section/studies-section.helpers.ts
@@ -3,4 +3,4 @@ import { dateExtractor, sortByDate } from '../../helpers';
 import { StudiesSectionVm } from './studies-section.vm';
 
 export const sortStudiesByDate = (studies: StudiesSectionVm[]): StudiesSectionVm[] =>
-  sortByDate(studies, dateExtractor) as StudiesSectionVm[];
+  sortByDate(studies) as StudiesSectionVm[];
diff --git a/packages/manfred-common/src/helpers/date-helpers.ts b/packages/manfred-common/src/helpers/date-helpers.ts
@@ -6,8 +6,7 @@ export const dateExtractor = (item: StudiesSectionVm | ExperienceVm | Role): num
   'roles' in item ? new Date(item.roles[0].startDate).getTime() : new Date(item.startDate).getTime();
 
 export const sortByDate = (
-  array: StudiesSectionVm[] | ExperienceVm[] | Role[],
-  dateExtractor: (item: StudiesSectionVm | ExperienceVm | Role) => number
+  array: StudiesSectionVm[] | ExperienceVm[] | Role[]
 ): StudiesSectionVm[] | ExperienceVm[] | Role[] =>
   array.sort(
     (a: ExperienceVm | StudiesSectionVm | Role, b: ExperienceVm | StudiesSectionVm | Role) =>