Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added message #227

Merged
merged 2 commits into from
Oct 4, 2023
Merged

added message #227

merged 2 commits into from
Oct 4, 2023

Conversation

juanpms2
Copy link
Member

@juanpms2 juanpms2 commented Oct 4, 2023

Closed #225

brauliodiez
brauliodiez reviewed Oct 4, 2023
View reviewed changes
apps/react-app/src/common-app/components/export-config/export-config.component.tsx Outdated
@@ -15,6 +15,8 @@ export const ExportConfig: React.FC<Props> = props => {
const [exportHTMLSettings, setExportHTMLSettings] = React.useState<ExportHTMLSettings>({
primaryColor: theme.palette.primary[600],
});
const [isDownload, setIsDownload] = React.useState<boolean>(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isDownloadInProgress setIsDownloadInProgress

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is fixed

brauliodiez
brauliodiez reviewed Oct 4, 2023
View reviewed changes
apps/react-app/src/common-app/components/export-config/export-config.component.tsx Outdated

setTimeout(() => {
cancelExport();
}, 2500);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saco este valor a un constante fuera del componente en el mismo fichero

DOWNLOAD_MESSAGE_TIMEOUT 2500

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is fixed

@brauliodiez brauliodiez merged commit 6a20179 into feature/develop Oct 4, 2023
1 check passed
@brauliodiez brauliodiez deleted the feature/#225-close-modal-dialog-and-display-message-when-download-cv branch October 4, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brauliodiez brauliodiez brauliodiez left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[manfred2HTML] Close modal dialog and display message when download cv
2 participants
@juanpms2 @brauliodiez