Feature/#230 experience and studies sorted by date #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpms2
reviewed
Oct 23, 2023
| @@ -0,0 +1,15 @@ | |||
| import { ExperienceVm } from './experience-section.vm'; | |||
| import { dateExtractor, sortByDate } from '../../helpers'; | |||
There was a problem hiding this comment.
Use '@/helpers' on import and move it at first line
There was a problem hiding this comment.
With import in this way I get test failures
juanpms2
reviewed
Oct 23, 2023
| export const mapSortedRolesIntoExperience = (experience: ExperienceVm[]): ExperienceVm[] => | ||
| experience.map(experienceItem => sortRolesByDate(experienceItem)); | ||
|
|
||
| export const sortExperienceByDate = (experience: ExperienceVm[]): ExperienceVm[] => |
There was a problem hiding this comment.
What's the difference between sortExperienceByDate and sortByDate functions?
There was a problem hiding this comment.
In sortExperienceByDate, specifies that the sorting is performed on the first element of the array as a parameter of dateExtractor
juanpms2
reviewed
Oct 23, 2023
| @@ -1,6 +1,7 @@ | |||
| import { ManfredAwesomicCV } from '../../model'; | |||
juanpms2
reviewed
Oct 23, 2023
| @@ -0,0 +1,5 @@ | |||
| import { sortByDate } from '../../helpers'; | |||
There was a problem hiding this comment.
Same as with experience. With import in this way I get test failures
|
Added missing typing on 'b' in sortExperienceByDate function |
migalko94
deleted the
feature/#230-experience-and-studies-sorted-by-date
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.