Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/#245 review the template in markdown and check all the fields #313

Open
wants to merge 4 commits into
base: feature/develop
Choose a base branch
from

Conversation

MiguelJiRo
Copy link
Collaborator

Added some checks to the markdown template fields

@juanpms2
Copy link
Member

You need to control if the section is required. For example: profile.description is a optional field, if we don't have information we shouldn't display that section. The same with other ones.

@MiguelJiRo
Copy link
Collaborator Author

Hello 😃 ! using the data from "manfred-schema.model.ts", these are all the conditions that have been checked and modified:

  1. experience is an optional field (experienceCollection in the section.part.js)
    • job.description move into roles condition, now includes the rest of the code in this condition
    • startDate is a required field, it has returned to the original code
  2. hardSkills (knowledge) is an optional field (hardSkillsCollection in the section.part.js)
  3. languages (knowledge) is an optional field (languageCollection in the section.part.js)
    • language.level is an optional field
  4. profile?.description (aboutMe) is an optional field (profile in the section.part.js)
  5. profile?.relevantLinks (aboutMe) is an optional field (profile in the section.part.js)
  6. softSkills (knowledge) is an optional field (softSkillsCollection in the section.part.js)
  7. studies (knowledge) is an optional field (studiesCollection in the section.part.js)
    • The field study?.startDate is a required field, condition modified to ask for study?.finishDate because it is an optional field

@juanpms2
Copy link
Member

juanpms2 commented Jan 9, 2024

Thanks @MiguelJiRo .

@brauliodiez this pull request is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants