begin better cli

crates/game-solver/src/lib.rs

@@ -37,7 +37,7 @@ fn negamax<T: Game<Player = impl TwoPlayer> + Eq + Hash>(
 
     // check if this is a winning configuration
     if let Ok(Some(board)) = game.find_immediately_resolvable_game() {
-        return Ok(upper_bound(&board) - board.move_count() as isize - 1);
+        return Ok(upper_bound(&board) - board.move_count() as isize);
     }
 
     // fetch values from the transposition table

crates/games/src/nim/mod.rs

@@ -115,7 +115,7 @@ impl Game for Nim {
 impl Display for Nim {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         for (i, heap) in self.heaps.iter().enumerate() {
-            write!(f, "heap {i}: {heap}")?;
+            writeln!(f, "Heap {i}: {heap}")?;
         }
 
         Ok(())
@@ -168,3 +168,13 @@ impl TryFrom<NimArgs> for Nim {
         Ok(game)
     }
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn max_moves_is_heap_sum() {
+        assert_eq!(Nim::new(vec![3, 5, 7]).max_moves(), Some(3 + 5 + 7));
+    }
+}

crates/games/src/sprouts/mod.rs

@@ -1,6 +1,11 @@
 #![doc = include_str!("./README.md")]
 
+use game_solver::game::Game;
 use petgraph::matrix_graph::MatrixGraph;
 
 #[derive(Clone)]
 pub struct Sprouts(MatrixGraph<(), ()>);
+
+// impl Game for Sprouts {
+
+// }

crates/games/src/util/cli/mod.rs

@@ -3,12 +3,12 @@ use core::hash::Hash;
 use game_solver::{
     game::{Game, GameState},
     par_move_scores,
-    player::TwoPlayer,
+    player::{ImpartialPlayer, TwoPlayer},
 };
-use std::fmt::{Debug, Display};
+use std::{any::TypeId, fmt::{Debug, Display}};
 
 pub fn play<
-    T: Game<Player = impl TwoPlayer + Debug> + Eq + Hash + Sync + Send + Display + 'static,
+    T: Game<Player = impl TwoPlayer + Debug + 'static> + Eq + Hash + Sync + Send + Display + 'static,
 >(
     game: T,
 ) where
@@ -20,7 +20,12 @@ pub fn play<
 
     match game.state() {
         GameState::Playable => {
-            println!("Player {:?} to move", game.player());
+            if TypeId::of::<T::Player>() != TypeId::of::<ImpartialPlayer>() {
+                println!("Player {:?} to move", game.player());
+            } else {
+                // TODO: can we assert that game.player() is the next player?
+                println!("Impartial game; Next player is moving.");
+            }
 
             let move_scores = par_move_scores(&game);
             let mut move_scores = move_scores