Skip to content

Commit

Permalink
Merge pull request #10 from Lerer/multi-result-pull
Browse files Browse the repository at this point in the history
Multi result pull
  • Loading branch information
Lerer authored Oct 7, 2020
2 parents d6de0e6 + a27a357 commit 9f9f538
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 8 deletions.
14 changes: 12 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,19 @@ All notable changes to the "veracode-sca" extension will be documented in this f

Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how to structure this file.

## [Unreleased]

- Initial release
### 0.1.1-beta

- Increase max issues import to 1000 issues
- Update the note for missing issues if there are more than 1000

### 0.1.0-beta

- Note added for projects with more than 100 issues

### 0.0.3

- Add a view to refresh and view the local working folder for SCA libraries and vulnerabilities

### 0.0.2

Expand Down
7 changes: 6 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,18 @@ This extension contributes the following settings:

Images and icons need update

The plugin is currently only support 100 issues in a single project. In case there are more issues, you'll see a note in the issues pane:
The plugin is currently only support ~~100~~ 1000 issues in a single project. In case there are more issues, you'll see a note in the issues pane similar to the image below:
<p align=center>
<img src="media/ScreenShot_2020-09-24_at_10.17.51_am.png" width="300">
</p>

## Release Notes

### 0.1.1-beta

- Increase max issues import to 1000 issues
- Update the note for missing issues if there are more than 1000

### 0.1.0-beta

- Note added for projects with more than 100 issues
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "veracode-sca",
"displayName": "Veracode SCA (TS)",
"description": "",
"version": "0.1.0-beta",
"version": "0.1.1-beta",
"publisher": "Lerer",
"repository": {
"url": "https://github.com/Lerer/vscode-veracode-sca"
Expand Down
Binary file added release/veracode-sca-0.1.1-beta.vsix
Binary file not shown.
2 changes: 1 addition & 1 deletion src/veracode/veracodeAPIWrapper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const requests: RequestDetails[] = [
},
{
name: "getProjectIssues",
path: '/srcclr/v3/workspaces/<workspace_id>/issues?project_id=<project_id>&size=100',
path: '/srcclr/v3/workspaces/<workspace_id>/issues?project_id=<project_id>&size=1000',
host: 'api.veracode.com',
method: 'GET',
queryParams: ''
Expand Down
6 changes: 3 additions & 3 deletions src/views/SCAIssuesViewHandler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {specificRequest} from '../veracode/veracodeAPIWrapper';
import {getSeverityRatingFromCVSS} from '../veracode/constants';
import * as path from 'path';

const MAX_ISSUES = 100;
const MAX_ISSUES = 1000;

interface SCAIssueElement {
id: string,
Expand Down Expand Up @@ -59,7 +59,7 @@ export class SCAIssuesViewProvider implements vscode.TreeDataProvider<SCAIssueE
this._onDidChangeTreeData.fire(undefined);
}

cleanIssues() {
cleanIssues() {
//this.currentWorkspaceId = '';
//this.currentProjectId = '';
scaIssues = {};
Expand Down Expand Up @@ -96,7 +96,7 @@ function getIssueTreeItem(element:SCAIssueElement): vscode.TreeItem {
console.log(scaIssues.page);
if (element.type==='more'){
let total:number = scaIssues.page.total_elements;
let parentLabel = `Showing only 100 out of ${total} issues`;
let parentLabel = `Showing only ${MAX_ISSUES} out of ${total} issues`;
return {
label: parentLabel,
collapsibleState: vscode.TreeItemCollapsibleState.None
Expand Down

0 comments on commit 9f9f538

Please sign in to comment.