Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cody/refine toast styling #607

Merged
merged 23 commits into from
Nov 6, 2024
Merged

Cody/refine toast styling #607

merged 23 commits into from
Nov 6, 2024

Conversation

kepsteen
Copy link
Contributor

@kepsteen kepsteen commented Oct 10, 2024 •
edited
Loading

Closes #500

  • Modified the position of the toaster to place toasts in the bottom left on desktop
  • Added max-width class to Alert
Screenshot 2024-10-22 at 12 16 33 PM Screenshot 2024-10-22 at 12 02 06 PM

@appwrite Appwrite
Copy link

appwrite bot commented Oct 10, 2024 •
edited
Loading

Gridiron Survivor Application 6616ea581ef9f5521c7d

Function ID Status Action
Your function deployment is in progress. Please check back in a few minutes for the updated status.

Project name: Gridiron Survivor Application
Project ID: 6616ea581ef9f5521c7d

Function ID Status Action
userAuth 6626fef885a9f630442b waiting Waiting to build View Logs

Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.

💡 Did you know?
Appwrite has a Discord community with over 16 000 members. Come join us!

@vercel Vercel
Copy link

vercel bot commented Oct 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gridiron-survivor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2024 10:14pm
gridiron-survivor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2024 10:14pm

@shashilo

This comment was marked as resolved.

Sign in to view
@Danielle254 Danielle254 self-requested a review October 11, 2024 13:32
ryandotfurrer
ryandotfurrer requested changes Oct 11, 2024
View reviewed changes
app/(main)/layout.tsx Outdated Show resolved Hide resolved
components/Alert/Alert.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
components/AlertNotification/AlertNotification.tsx Outdated Show resolved Hide resolved
components/AlertNotification/AlertNotification.tsx Outdated Show resolved Hide resolved
chris-nowicki

This comment was marked as resolved.

Sign in to view

@kepsteen
Copy link
Contributor Author

@chris-nowicki

@kepsteen this is a general comment. Can we make the x close out button centered. It is currently at the top and think it might look better when centered vertically on the toast._

I went out of scope by adding the button so I will be removing from this PR.

@Danielle254
Copy link
Contributor

@kepsteen please do a pull from the develop branch and resolve any merge conflicts

@kepsteen
Copy link
Contributor Author

@Danielle254 what do you mean by that?. Do I checkout my branch and do git pull origin develop?

@Danielle254
Copy link
Contributor

@kepsteen yep!

Danielle254
Danielle254 reviewed Oct 13, 2024
View reviewed changes
Copy link
Contributor

@Danielle254 Danielle254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Cody! Just waiting for requested changes to be made and comments resolved before approving. As you make updates, be sure to push your code back up to this branch on GitHub so that we can see the changes.

Danielle254
Danielle254 previously approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@Danielle254 Danielle254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@allyroo
Copy link

allyroo commented Oct 24, 2024 •
edited
Loading

Just saw the updated image at the top. Looks good! @kepsteen

@kepsteen kepsteen dismissed stale reviews from Danielle254 and choir241 via 4eb8308 October 30, 2024 17:02
shashilo
shashilo previously approved these changes Oct 30, 2024
View reviewed changes
vmaineng
vmaineng previously approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@vmaineng vmaineng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, Cody!

@kepsteen kepsteen dismissed stale reviews from vmaineng and shashilo via a38c21f November 2, 2024 22:12
@shashilo shashilo dismissed stale reviews from chris-nowicki and ryandotfurrer November 6, 2024 17:51

old requests

@kepsteen kepsteen merged commit a3b8c27 into develop Nov 6, 2024
5 checks passed
@kepsteen kepsteen deleted the Cody/refine-toast-styling branch November 6, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmaineng vmaineng vmaineng approved these changes

@braydoncoyer braydoncoyer braydoncoyer approved these changes

@mhchen mhchen mhchen approved these changes

@shashilo shashilo shashilo left review comments

@chris-nowicki chris-nowicki Awaiting requested review from chris-nowicki

@ryandotfurrer ryandotfurrer Awaiting requested review from ryandotfurrer

@Danielle254 Danielle254 Awaiting requested review from Danielle254

@choir241 choir241 Awaiting requested review from choir241

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: UI/UX: Refine styling of Toasts
10 participants
@kepsteen @shashilo @Danielle254 @allyroo @mhchen @braydoncoyer @ryandotfurrer @choir241 @vmaineng @chris-nowicki