Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cody/fix getUserLeagues function #647

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Cody/fix getUserLeagues function #647

merged 3 commits into from
Oct 30, 2024

Conversation

kepsteen
Copy link
Contributor

@kepsteen kepsteen commented Oct 30, 2024 •
edited
Loading

Closes #484

Appwrite returns an array with an empty string if the user is not in any leagues

  • changed the check to account for this
  • modified the test for getUserLeagues

@appwrite Appwrite
Copy link

appwrite bot commented Oct 30, 2024 •
edited
Loading

Gridiron Survivor Application 6616ea581ef9f5521c7d

Function ID Status Action
Your function deployment has failed. Please check the logs for more details and retry.

Project name: Gridiron Survivor Application
Project ID: 6616ea581ef9f5521c7d

Function ID Status Action
userAuth 6626fef885a9f630442b failed Failed View Logs

Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.

💡 Did you know?
You can use Avatars API to generate QR code for any text or URLs

@vercel Vercel
Copy link

vercel bot commented Oct 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gridiron-survivor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 7:04pm
gridiron-survivor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 7:04pm

@kepsteen kepsteen changed the title Cody/change empty leagues check to array with empty string Cody/fix getUserLeagues function Oct 30, 2024
vmaineng
vmaineng approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@vmaineng vmaineng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the unit test. LGTM! :)

@kepsteen kepsteen merged commit 96d4679 into develop Oct 30, 2024
5 checks passed
@kepsteen kepsteen deleted the Cody/fix-getUserLeagues branch October 30, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmaineng vmaineng vmaineng approved these changes

@mhchen mhchen mhchen approved these changes

@shashilo shashilo Awaiting requested review from shashilo shashilo is a code owner

@braydoncoyer braydoncoyer Awaiting requested review from braydoncoyer

@ryandotfurrer ryandotfurrer Awaiting requested review from ryandotfurrer

@FurrerW FurrerW Awaiting requested review from FurrerW

@HoldUpFjord HoldUpFjord Awaiting requested review from HoldUpFjord

@Danielle254 Danielle254 Awaiting requested review from Danielle254

@alexappleget alexappleget Awaiting requested review from alexappleget

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix getUserLeagues Function
3 participants
@kepsteen @mhchen @vmaineng