perp-4102 | burn half of the house LP shares #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an incentivization mechanism to provide additional value over time to liquidity providers.
Deploying levana-predict with
|
| Latest commit: |
3c464b0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c21c1623.levana-predict.pages.dev |
| Branch Preview URL: | https://perp-4102-burn-house-lps.levana-predict.pages.dev |
contract/src/execute.rs
Outdated
| @@ -338,7 +338,8 @@ fn withdraw( | |||
|
|
|||
| let Sell { funds, returned } = market.sell(outcome, tokens)?; | |||
|
|
|||
| if share_info.get_outcome(&market, outcome)?.is_zero() { | |||
| if share_info.get_outcome(&market, outcome, false)?.is_zero() { | |||
| println!("here1"); | |||
There was a problem hiding this comment.
I believe you didn't mean to check this in..
There was a problem hiding this comment.
Doh, good catch, thanks!
| @@ -83,6 +83,7 @@ pub fn sanity(store: &dyn Storage, env: &Env) { | |||
| assert_eq!(tokens.0, pool_size.0); | |||
| } | |||
|
|
|||
| // FIXME modify check to include in all wallets if they have a liquidity share | |||
There was a problem hiding this comment.
Not sure if you want to address this as part of this PR or later.
There was a problem hiding this comment.
Fixed in the next PR.
lvn-hasky-dragon
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an incentivization mechanism to provide additional value over time to liquidity providers.