PERP-4088 | Display estimated shares amount to be bought #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying levana-predict with
|
| Latest commit: |
305754c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4e53b1fa.levana-predict.pages.dev |
| Branch Preview URL: | https://perp-4088-display-amount-of.levana-predict.pages.dev |
lvn-rusty-dragon
approved these changes
Sep 20, 2024
| ): Shares => { | ||
| const selectedPool = | ||
| market.possibleOutcomes.find((outcome) => outcome.id === selectedOutcome) | ||
| ?.poolShares.units ?? BigNumber(0) |
There was a problem hiding this comment.
NIT: I'd probably throw an exception if we can't find this outcome instead of returning 0.
|
I figured out why the numbers don't match up, it's because of fees and the liquidity portion. I'll put together a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new shares precision implementation so this PR is daisy-chained onto
PERP-4099.The formula in the doc uses just two outcomes, but I tried to implement this for an arbitrary number of outcomes. The estimated amounts seem to be close to the actual amount received after a purchase, but they don't match exactly. Let me know if I missed something in the formulas.