Outcome assertion added #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying levana-predict with
|
| Latest commit: |
8a53688
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://86f4b1d2.levana-predict.pages.dev |
| Branch Preview URL: | https://assert-add.levana-predict.pages.dev |
lvn-rusty-dragon
suggested changes
Sep 4, 2024
contract/src/execute.rs
Outdated
| @@ -104,6 +104,8 @@ fn add_market( | |||
| }); | |||
| } | |||
|
|
|||
| assert!(outcomes.len() == 2, "Supports only two outcomes"); | |||
There was a problem hiding this comment.
Probably better to make this a runtime check as part of the production runtime, returning an error message instead of just panicking.
There was a problem hiding this comment.
Yeah, agree. Updated.
lvn-rusty-dragon
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.