-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maven central repo requirements #371
base: main
Are you sure you want to change the base?
Conversation
This also updates artifactId to lowercase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have just a few questions.
|
||
<!-- SCM (Source Code Management) --> | ||
<scm> | ||
<connection>scm:git:git://github.com/LiUSemWeb/HeFQUIN.git</connection> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have :git:
twice here. Is that a typo?
<scm> | ||
<connection>scm:git:git://github.com/LiUSemWeb/HeFQUIN.git</connection> | ||
<developerConnection>scm:git:ssh://github.com:LiUSemWeb/HeFQUIN.git</developerConnection> | ||
<url>http://github.com/LiUSemWeb/HeFQUIN/tree/main</url> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why you didn't simply put http://github.com/LiUSemWeb/HeFQUIN
? (I'm just curious)
Also, shouldn't it be https://
instead of http://
?
<!-- Project Meta Data --> | ||
<name>HeFQUIN</name> | ||
<description>HeFQUIN is a query federation engine for heterogeneous federations of graph data sources, including federations of knowledge graphs.</description> | ||
<url>http://github.com/LiUSemWeb/hefquin</url> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<url>http://github.com/LiUSemWeb/hefquin</url> | |
<url>https://liusemweb.github.io/HeFQUIN/</url> |
Or not?
First version of metadata required in pom.xml.