Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONEM-10964 Allow to compile webkit using gcc 9.3.x series #80

Open
wants to merge 1 commit into
base: lgi-master
Choose a base branch
from

Conversation

dwrobel
Copy link

@dwrobel dwrobel commented Jan 26, 2022

Mitigates the following build error:

1_2.22.1+git-r0/git/Source/JavaScriptCore/API/glib/JSCVirtualMachine.cpp:48:13:
error: G_ADD_PRIVATE [-Werror]
48 | WEBKIT_DEFINE_TYPE(JSCVirtualMachine, jsc_virtual_machine, G_TYPE_OBJECT)
| ^~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors

Mitigates the following build error:

1_2.22.1+git-r0/git/Source/JavaScriptCore/API/glib/JSCVirtualMachine.cpp:48:13:
error: G_ADD_PRIVATE [-Werror]
   48 | WEBKIT_DEFINE_TYPE(JSCVirtualMachine, jsc_virtual_machine, G_TYPE_OBJECT)
      |             ^~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
@dwrobel dwrobel changed the title ONEM-10964 Allow to compile webkit using gcc 7.x series ONEM-10964 Allow to compile webkit using gcc 9.3.x series Jan 27, 2022
Copy link

@jacek-skiba-red jacek-skiba-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we cannot add -Wno-error= for this specific problem?

@jacek-skiba-red jacek-skiba-red force-pushed the lgi-master branch 2 times, most recently from ba1641a to f543094 Compare April 13, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants