Development

.github/workflows/deploy-staging.yml

@@ -2,7 +2,7 @@ name: Deploy backend to staging
 
 on:
   push:
-    branches: ['development', 'gh-actions', 's23-docker-compose-tests']
+    branches: ['development', 'gh-actions', s23-docker-compose-tests]
 
 env:
   REGISTRY: ghcr.io

Dockerfile.staging

@@ -1,5 +1,5 @@
 # Stage 1: Build
-FROM node:alpine as builder
+FROM node:16-bullseye as builder
 
 WORKDIR /app
 
@@ -14,10 +14,12 @@ COPY . .
 RUN npm run build
 
 # Stage 2: Run
-FROM node:alpine
+FROM node:16-bullseye
 
 WORKDIR /app
 
+# Copy SQL scripts for database initialization MAYBE NOT NEEDED in production/staging
+COPY sql /app/sql
 # Copy built assets from builder stage
 COPY --from=builder /app/build ./build
 # Only copy the necessary files for runtime

docker-compose-staging.yml

@@ -6,6 +6,6 @@ services:
     image: ${IMAGE_NAME}
     build:
       context: .
-      dockerfile: Dockerfile
+      dockerfile: Dockerfile.staging
     ports:
       - 3002:3002

robot/common.resource

@@ -8,3 +8,5 @@ ${BACKENDTESTPASSWORD}      default
 
 # this will be set in initial login test
 ${bearerToken}              default
+${userId}                   default 
+

robot/tests/01_loginTests.robot

@@ -33,4 +33,6 @@ Verify user can login
     ${response}=    POST    ${URL}/auth/login    json=${data}    expected_status=200
     Should Be True    ${response.json()['ok']}
     Set Global Variable    ${bearerToken}    access_token=${response.json()['secret']}
+    Set Global Variable    ${userId}    ${response.json()['userId']}
     Log To Console    ${bearerToken}
+    Log To Console    ${userId}

robot/tests/04_bookTests.robot

@@ -36,16 +36,6 @@ Verify that a nonexistent book can't be deleted
     ${response}=    DELETE    url=${URL}/book/?id=12321&${bearerToken}    expected_status=403
     Should Not Be True    ${response.json()['ok']}
 
-Verify user can check all borrowed books
-    ${response}=    GET    url=${URL}/borrow/all?${bearerToken}    expected_status=200
-
-Verify that user cannot get a nonexisting borrowed book
-    ${response}=    GET    url=${URL}/borrow/?id=123456789&${bearerToken}    expected_status=200
-    Should Be Equal    ${response.json()}    ${None}
-
-Verify that user can check borrowed book by id
-    ${response}=    GET    url=${URL}/borrow/?id=1&${bearerToken}    expected_status=200
-    Should Be Equal    ${response.json()['id']}    ${1}
 
 # Verify that book can be updated
 #    &{data}=    Create dictionary    { library_user=2    title=Fake asdf    image=http://books.google.com/books/content?id=ILqrxQEACAAJ&printsec=frontcover&img=1&zoom=1&source=gbs_api    author=Test Author     year=2022    isbn=123-242-421    topic=js    location=Fake location    deleted=0}

robot/tests/05_borrowTests.robot

@@ -0,0 +1,32 @@
+*** Settings ***
+Resource    ../common.resource
+Library     RequestsLibrary
+Library     String
+
+*** Test Cases ***
+Verify that all borrows can be found
+    ${response}=    GET    url=${URL}/borrow/all?${bearerToken}    expected_status=200
+
+Verify that user can find borrow by id
+    ${response}=    GET    url=${URL}/borrow/?id=1&${bearerToken}    expected_status=200
+    Should Be Equal    ${response.json()['id']}    ${1}
+
+Verify that user can't find borrow by non-existing id
+    ${response}=    GET    url=${URL}/borrow/?id=12345&${bearerToken}    expected_status=200
+    Should Be Equal    ${response.json()}    ${none}
+
+Verify that user can check borrowed book by id
+    ${response}=    GET    url=${URL}/borrow/?id=1&${bearerToken}    expected_status=200
+    Should Be Equal    ${response.json()['id']}    ${1}
+
+Verify that user can't delete non-existing borrow
+    &{data}=    Create dictionary
+    ...    { bookId=1234 }
+    ${response}=    DELETE    url=${URL}/borrow?${bearerToken}    json=${data}    expected_status=403
+
+Verify that user can get current borrows
+    ${response}=    GET    url=${URL}/borrow/current?${bearerToken}    expected_status=200
+
+Verify that user can get borrows by session
+    ${response}=    GET    url=${URL}/borrow/session?${bearerToken}    expected_status=200
+

robot/tests/06_booklistTests.robot

@@ -0,0 +1,82 @@
+*** Settings ***
+Resource    ../common.resource
+Library     RequestsLibrary
+Library     String
+
+*** Variables ***
+${okTrueJson}    {"ok":true}
+${okFalseJson}    {"ok":false}
+
+*** Test Cases ***
+Verify that user can add booklists
+    ${data}=    Create dictionary
+    ...     name=Testlist     
+    ${response}=    POST   url=${URL}/booklist?${bearerToken}    json=${data}    expected_status=200
+
+Verify that user can check all booklists
+    ${response}=    GET    url=${URL}/booklist/all?${bearerToken}    expected_status=200
+
+Verify that user can check all users booklists
+    ${response}=    GET    url=${URL}/booklist/user?${bearerToken}    expected_status=200
+    ${bookList}=    Evaluate    json.loads('''${response.text}''')
+    Length Should Be    ${bookList}    1
+
+Verify that user can add books to list
+    ${data}=    Create dictionary
+    ...    list=1
+    ...    book=2  
+    ${response}=    POST   url=${URL}/booklistentry?${bearerToken}    json=${data}    expected_status=200
+    Should Be Equal As Strings    ${response.text}    ${okTrueJson}
+
+Verify that user can't add non-existing books to list
+    ${data}=    Create dictionary
+    ...    list=1
+    ...    book=2123  
+    ${response}=    POST   url=${URL}/booklistentry?${bearerToken}    json=${data}    expected_status=500
+    Should Be Equal As Strings    ${response.text}    ${okFalseJson}
+
+Verify that user can't add books to non-existing list
+    ${data}=    Create dictionary
+    ...    list=11234
+    ...    book=2  
+    ${response}=    POST   url=${URL}/booklistentry?${bearerToken}    json=${data}    expected_status=500
+    Should Be Equal As Strings    ${response.text}    ${okFalseJson}
+
+Verify that user can get all booklistentrys
+    ${response}=    GET   url=${URL}/booklistentry/all?${bearerToken}   expected_status=200
+
+Verify that user get all booklistentrys based on listId
+    ${response}=    GET   url=${URL}/booklistentry/list?${bearerToken}&id=1    expected_status=200
+    ${bookList}=    Evaluate    json.loads('''${response.text}''')
+    Length Should Be    ${bookList}    1
+
+Verify that user get all books in list based on listId
+    ${response}=    GET   url=${URL}/booklist/books?${bearerToken}&id=1    expected_status=200
+    ${bookList}=    Evaluate    json.loads('''${response.text}''')
+    Length Should Be    ${bookList}    1
+
+Verify that user can modify booklist
+    ${data}=    Create dictionary
+    ...    id=1
+    ...    name=New name  
+    ${response}=    PUT   url=${URL}/booklist?${bearerToken}    json=${data}    expected_status=200
+    Should Be Equal As Strings    ${response.text}    ${okTrueJson}
+
+Verify that user can't modify non-existing booklist
+    ${data}=    Create dictionary
+    ...    id=12345
+    ...    name=Wrong list  
+    ${response}=    PUT   url=${URL}/booklist?${bearerToken}    json=${data}    expected_status=200
+    Should Be Equal As Strings    ${response.text}    ${okFalseJson}
+
+Verify that user can delete booklist
+    ${data}=    Create dictionary
+    ...    id=1
+    ${response}=    DELETE   url=${URL}/booklist?${bearerToken}    json=${data}    expected_status=200
+    Should Be Equal As Strings    ${response.text}    ${okTrueJson}
+
+Verify that user can't delete non-existing booklist
+    ${data}=    Create dictionary
+    ...    id=1123
+    ${response}=    DELETE   url=${URL}/booklist?${bearerToken}    json=${data}    expected_status=200
+    Should Be Equal As Strings    ${response.text}    ${okFalseJson}

robot/tests/07_bookFavoriteTests.robot

@@ -0,0 +1,34 @@
+*** Settings ***
+Resource    ../common.resource
+Library     RequestsLibrary
+Library     String
+
+*** Test Cases ***
+Verify that user can add favorite
+    &{data}=    Create dictionary
+    ...     bookId=4 
+    ${response}=    POST    url=${URL}/favorite?${bearerToken}    json=${data}    expected_status=200
+    Should Be True    ${response.json()['ok']}
+
+Verify that user can get counts for all favorited books
+    ${response}=    GET    url=${URL}/favorite/counts?${bearerToken}    expected_status=200
+
+Verify that user can get count for books
+    ${response}=    GET    url=${URL}/favorite/count?${bearerToken}&bookId=4    expected_status=200
+    Should Be Equal    ${response.json()['count']}    ${1}
+
+Verify that user can check if book is favorited
+    ${response}=    GET    url=${URL}/favorite/check?${bearerToken}&bookId=4    expected_status=200
+    Should Be Equal    ${response.json()['isFavorited']}    ${true}
+
+Verify that user can delete book from favorites
+    &{data}=    Create dictionary
+    ...     bookId=4 
+    ${response}=    DELETE    url=${URL}/favorite?${bearerToken}    json=${data}    expected_status=200
+    Should Be True    ${response.json()['ok']}
+
+Verify that user can't delete book that isn't favorited
+    &{data}=    Create dictionary
+    ...     bookId=3123 
+    ${response}=    DELETE    url=${URL}/favorite?${bearerToken}    expected_status=400
+    Should Not Be True    ${response.json()['ok']}

robot/tests/08_bookReviewTests.robot

@@ -0,0 +1,48 @@
+*** Settings ***
+Resource    ../common.resource
+Library     RequestsLibrary
+Library     String
+
+*** Variables ***
+${okTrueJson}    {"ok":true}
+${okFalseJson}    {"ok":false}
+
+
+*** Test Cases ***
+Verify that user can add review to book
+    ${data}=    Create dictionary
+    ...    bookId=1
+    ...    comment='Great book for everyone!'
+    ...    rating=5    
+    ${response}=    POST   url=${URL}/review?${bearerToken}    json=${data}    expected_status=200
+    Should Be Equal As Strings    ${response.text}    ${okTrueJson}
+
+Verify that user can't add review to non-existing book
+    ${data}=    Create dictionary
+    ...    bookId=1124
+    ...    comment='Wrong book'
+    ...    rating=1   
+    ${response}=    POST   url=${URL}/review?${bearerToken}    json=${data}    expected_status=500
+    Should Be Equal As Strings    ${response.text}    ${okFalseJson}
+
+Verify that user can check all reviews
+    ${response}=    GET   url=${URL}/review/all?${bearerToken}    expected_status=200
+
+Verify that user can check reviews for all books
+    ${response}=    GET   url=${URL}/review/reviews?${bearerToken}    expected_status=200   
+
+Verify that user can modify review
+    ${data}=    Create dictionary
+    ...    comment='Modified book'
+    ...    rating=1
+    ...    reviewId=1   
+    ${response}=    PUT   url=${URL}/review?${bearerToken}    json=${data}    expected_status=200
+    Should Be Equal As Strings    ${response.text}    ${okTrueJson}
+
+Verify that user can't modify non-existing review
+    ${data}=    Create dictionary
+    ...    comment='Again wrong book'
+    ...    rating=1
+    ...    reviewId=1234   
+    ${response}=    PUT   url=${URL}/review?${bearerToken}    json=${data}    expected_status=400
+    Should Not Be True    ${response.json()['ok']}

robot/tests/09_bookRequestTests.robot

@@ -0,0 +1,18 @@
+*** Settings ***
+Resource    ../common.resource
+Library     RequestsLibrary
+Library     String
+
+
+*** Test Cases ***
+Verify that user can add request
+    ${data}=    Create dictionary
+    ...    isbn=234-123-345
+    ...    title=Lizard Disco
+    ...    reason=Great book, easy to read 
+    ${response}=    POST   url=${URL}/bookrequest?${bearerToken}    json=${data}    expected_status=200
+
+Verify that user can check all users booklists
+    ${response}=    GET    url=${URL}/bookrequest/all?${bearerToken}    expected_status=200
+    ${list}=    Evaluate    json.loads('''${response.text}''')
+    Length Should Be    ${list}    1

robot/tests/10_bookReservationTests.robot

@@ -0,0 +1,67 @@
+*** Settings ***
+Resource    ../common.resource
+Library     RequestsLibrary
+Library     String
+
+*** Variables ***
+${okTrueJson}    {"ok":true}
+${okFalseJson}    {"ok":false}
+
+*** Test Cases ***
+Verify that user can add reservations
+    ${data}=    Create dictionary
+    ...    bookId=2     
+    ${response}=    POST   url=${URL}/bookreservation?${bearerToken}    json=${data}    expected_status=200
+    Should Be Equal As Strings    ${response.text}    ${okTrueJson}
+
+Verify that user can't add reservations for non-existing book
+    ${data}=    Create dictionary
+    ...    bookId=1123     
+    ${response}=    POST   url=${URL}/bookreservation?${bearerToken}    json=${data}    expected_status=500
+    Should Be Equal As Strings    ${response.text}    ${okFalseJson}
+
+Verify that user can check all reservations
+    ${response}=    GET    url=${URL}/bookreservation/all?${bearerToken}    expected_status=200
+    ${list}=    Evaluate    json.loads('''${response.text}''')
+    Length Should Be    ${list}    1
+
+Verify that user can check all extended reservations
+    ${response}=    GET    url=${URL}/bookreservation/all/extended?${bearerToken}    expected_status=200
+    ${list}=    Evaluate    json.loads('''${response.text}''')
+    Length Should Be    ${list}    1
+
+Verify that user can check reservation based on bookId
+    ${data}=    Create dictionary
+    ...    bookId=2     
+    ${response}=    GET   url=${URL}/bookreservation/book?${bearerToken}    json=${data}    expected_status=200
+    Should Be Equal    ${response.json()['bookId']}    ${2}
+
+Verify that user can't check reservation based on non-existing bookId
+    ${data}=    Create dictionary
+    ...    bookId=33245     
+    ${response}=    GET   url=${URL}/bookreservation/book?${bearerToken}    json=${data}    expected_status=200
+    Should Be Equal    ${response.json()}    ${none}
+
+Verify that user can cancel reservation
+    ${data}=    Create dictionary
+    ...    reservationId=1    
+    ${response}=    POST   url=${URL}/bookreservation/cancel?${bearerToken}    json=${data}    expected_status=200
+    Should Be Equal As Strings    ${response.text}    ${okTrueJson}
+
+Verify that user can check all current reservations
+    ${response}=    GET    url=${URL}/bookreservation/all/current?${bearerToken}    expected_status=200
+    ${list}=    Evaluate    json.loads('''${response.text}''')
+    Length Should Be    ${list}    0
+
+Verify that user can loan reservation
+    ${data}=    Create dictionary
+    ...    reservationId=1    
+    ${response}=    POST   url=${URL}/bookreservation/loan?${bearerToken}    json=${data}    expected_status=200
+    Should Be Equal As Strings    ${response.text}    ${okTrueJson}
+
+Verify that user can see their current reservations
+    ${data}=    Create dictionary
+    ...    userId=${userId}    
+    ${response}=    POST   url=${URL}/bookreservation/user/current?${bearerToken}    json=${data}    expected_status=200
+    ${list}=    Evaluate    json.loads('''${response.text}''')
+    Should Be Equal    ${response.json()}    ${none}