Updates: user interface changes #303
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd ask that |
|
I tried it and I found having the automatic update toggle expanding options above it, instead of below it, to be odd. I see the progression as "Will the system manage the updates? y/n" and then giving the user what their choices are when answering n. |
|
I have used my custom URL when there was no official releases.json for testing. Since there was an official releases.json for testing, I switched to this URL channel. But it would be nice to keep this feature, in case some "testing forks", like for instance Montellese "Media importing" would like to make use of it. |
antonlacon
force-pushed
the
update-selector
branch
from
72689b7
to
5a64424
Compare
antonlacon
force-pushed
the
update-selector
branch
2 times, most recently
from
67d2827
to
4ddc8c0
Compare
General review and cleanup of issues pointed out by pylint: unexpected indent could use f-strings not inializing variables in init redefining builtins too broad exceptions unneeded elses after returns unneeded parantheses == instead of is in evaluating True/False unused function parameters unused imports Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Addon will require Python >=3.9 Signed-off-by: Ian Leonard <[email protected]>
The release channel entry serves as a releases.json selector. stable: use releases.libreelec.tv/releases.json (stable builds) testing: use test.libreelec.tv/releases.json (nightly builds) custom: use a user designated URL for releases.json The 'custom' setting replaces the Show Custom Channels toggle. Adds a set_release_channel() function to refresh available build channels. Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
antonlacon
force-pushed
the
update-selector
branch
from
4ddc8c0
to
53d75ab
Compare
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
antonlacon
force-pushed
the
update-selector
branch
from
53d75ab
to
1311d6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #301. Its commits are included here. @flubshi you're the only user I know of who may create their own custom releases.json instead of using custom to fill in the LE testing one if you wish to test this.
This adds a ReleaseChannel toggle that switches the releases.json it uses from looking at releases.libreelec.tv to test.libreelec.tv to a user defined custom URL ("stable", "testing", and "custom" respectively).
This does some menu element hiding/revealing based on which release channel is being used (ex: autoupdates only apply to the stable channel). It also refreshes the releases.json it checks for version and available builds when the release channel changes. This can be a noticeable delay if on slow wifi between changing the release channel and the menu reloading.
Other interface changes are locale updates and deleting the custom channel 2 and 3 (custom channel 1 becomes the value used for the custom release channel).
Autoupdate is disabled (stats shared, but it halts the check after submission) if not on the stable release. Screenshots follow:
Default (stable channel, autoupdates on):
Stable channel, autoupdates off:
Testing channel:
Custom channel (URL would be shown if entered):
Draft until others look at the strings before squashing and 301 goes in.