-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arm64 windows zlib for msvc #73
Conversation
yes, fine but I don't understand what's mingw zlib binary doing in the repo? it's available in msys2 for both Intel and ARM: https://packages.msys2.org/base/mingw-w64-zlib (see Binary Packages) |
When I was building locally I could not get it to work without adding it. I agree it should not be there, maybe just something funny about my windows set up. I’ll do a fresh install of Windows next week and figure out why it didn’t work. |
ubuntu? are you cross-compiling from it to windows? |
Apologies, meant windows, corrected comment. |
well, on CI it works with zlib package from msys2 (and we tested that on local machines as well). I suggest to drop zlib mingw binary from the PR as well as remove the Intel version from the repo. |
You mean remove just mingw x64? |
X64 - remove from the repo as part of this PR, arm - drop from the PR |
Why drop arm from the PR. I’m confused now, that’s the whole purpose of the PR. |
Arm for mingw of course. Because binary is available in msys2 |
Gotcha, will do. |
…arm64 msvc zlib binary and remove mingw zlib binary
2a1084d
to
34cd17a
Compare
Done |
Added zlib static for ARM64 for Windows for both VS2109 and VS2022
@kambala-decapitator is this what you need?
@chewitt should support building on windows.