Quantum fixing #525
Merged
Quantum fixing #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… valid `r2q` to HTB queues, yielding many warnings on HTB queue setup. I'm not sure that 10 is the correct value, or that the formula is exactly right - but this patch adds an explicit quantum, following the specified (bytes per second / r2q) formula - with r2q set to a constant of 10. It eliminated the error messages on my test system. Committed for further testing.
…ited by HTB) for capacity estimation. May or may not actually do anything beneficial - this is a test.
|
Link to ISSUE #513 |
|
LARGE means 10x? |
|
Was actually having a heck of a time figuring out exactly what it meant, because it wasn't stable. I couldn't persuade Early testing shows that it loads without warnings (which makes the reload quite a lot faster), and doesn't seem to have had much effect on overall traffic or CPU. Did just back out the Cake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all HTB
r2qerrors. It appears thattcisn't settingr2qto 10 when working with a multi-headed queue of HTB trees. This patch uses the HTB defaultquantum = rate_bytes_per_second / r2qand applies it directly. It cut my network reload time by a LARGE amount.The PR also specifies Cake bandwidth explicitly rather than implying it from the parent HTB. Testing seems to indicate that doesn't do very much.