fix: prevent error when collect metadata #4783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the metadata field of a sign request is null, the array_merge function will throws an error because wait for an array as argument. Signed-off-by: Vitor Mattos <[email protected]>
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
samuelsonbrito
approved these changes
Apr 3, 2025
This was referenced Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the metadata field of a sign request is null, the array_merge function will throws an error because wait for an array as argument.
I also identified after implement the tests that when exists a previous value and this value is changed, the order of array_merge was prioritizing the previous value and the new value never was saved. I flipped the arguments of array_merge to prevent this.