Skip to content

feat: add group activity #4791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
Merged

feat: add group activity #4791

merged 2 commits into from
Apr 7, 2025

Conversation

samuelsonbrito
Copy link
Contributor

The activity group has been added to Libresign:

image

@github-project-automation github-project-automation bot moved this to 0. Needs triage in Roadmap Apr 4, 2025
@samuelsonbrito samuelsonbrito added this to the Next Major (32) milestone Apr 4, 2025
@samuelsonbrito samuelsonbrito force-pushed the feat/add-group-activity branch 2 times, most recently from ccab27c to e945493 Compare April 4, 2025 04:35
@samuelsonbrito samuelsonbrito requested a review from Any97Cris April 4, 2025 04:35
@samuelsonbrito samuelsonbrito force-pushed the feat/add-group-activity branch 2 times, most recently from 473ce61 to d5b9c9b Compare April 4, 2025 04:54
Copy link
Member

@vitormattos vitormattos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would be good to move other methods to abstract class and only maintain the methods with custom values. Maybe only the getIdentifier and getName

@samuelsonbrito samuelsonbrito force-pushed the feat/add-group-activity branch from d5b9c9b to 15b3a09 Compare April 4, 2025 13:57
Signed-off-by: Samuelson Brito <[email protected]>
@samuelsonbrito samuelsonbrito force-pushed the feat/add-group-activity branch from 6db94f8 to ec7f259 Compare April 4, 2025 14:07
@samuelsonbrito
Copy link
Contributor Author

I think that would be good to move other methods to abstract class and only maintain the methods with custom values. Maybe only the getIdentifier and getName

I was checking here and realized that the other methods are also customizable. These booleans configure whether the checkboxes will be checked by default or not, and the priority field defines the row's priority order.

@vitormattos
Copy link
Member

With most of cases use true, we can consider this as a default value to all settings. Maybe checked. If necessary, we can override the method with false.

@samuelsonbrito samuelsonbrito force-pushed the feat/add-group-activity branch from ec7f259 to 97f2de2 Compare April 6, 2025 03:33
@samuelsonbrito
Copy link
Contributor Author

Com a maioria dos casos de uso verdadeiro, podemos considerar isso como um valor padrão para todas as configurações. Talvez o cheque. Se necessário, podemos substituir o método com false.

Indeed. I’ve just pushed the adjustment.

@samuelsonbrito samuelsonbrito force-pushed the feat/add-group-activity branch from 97f2de2 to 69e8e53 Compare April 6, 2025 03:39
@samuelsonbrito samuelsonbrito force-pushed the feat/add-group-activity branch from 69e8e53 to fff9afe Compare April 6, 2025 03:58
Copy link
Member

@vitormattos vitormattos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Congrats!

The broken Action is at Coveralls side, last time that I saw, this service was out to maintenance.

We can go ahead and merge sending the backports.

@github-project-automation github-project-automation bot moved this from 0. Needs triage to 1. to do in Roadmap Apr 7, 2025
@samuelsonbrito
Copy link
Contributor Author

/backport to stable31

@samuelsonbrito
Copy link
Contributor Author

/backport to stable30

@samuelsonbrito samuelsonbrito self-assigned this Apr 7, 2025
@samuelsonbrito samuelsonbrito merged commit cc56909 into main Apr 7, 2025
68 of 69 checks passed
@samuelsonbrito samuelsonbrito deleted the feat/add-group-activity branch April 7, 2025 14:28
@github-project-automation github-project-automation bot moved this from 1. to do to 4. to release in Roadmap Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 4. to release
Development

Successfully merging this pull request may close these issues.

2 participants