-
-
Notifications
You must be signed in to change notification settings - Fork 66
feat: add group activity #4791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add group activity #4791
Conversation
ccab27c
to
e945493
Compare
473ce61
to
d5b9c9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would be good to move other methods to abstract class and only maintain the methods with custom values. Maybe only the getIdentifier
and getName
d5b9c9b
to
15b3a09
Compare
Signed-off-by: Samuelson Brito <[email protected]>
6db94f8
to
ec7f259
Compare
I was checking here and realized that the other methods are also customizable. These booleans configure whether the checkboxes will be checked by default or not, and the priority field defines the row's priority order. |
With most of cases use true, we can consider this as a default value to all settings. Maybe checked. If necessary, we can override the method with false. |
ec7f259
to
97f2de2
Compare
Indeed. I’ve just pushed the adjustment. |
97f2de2
to
69e8e53
Compare
Signed-off-by: Samuelson Brito <[email protected]>
69e8e53
to
fff9afe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Congrats!
The broken Action is at Coveralls side, last time that I saw, this service was out to maintenance.
We can go ahead and merge sending the backports.
/backport to stable31 |
/backport to stable30 |
The activity group has been added to Libresign: